Re: r150960 changed ltmain.sh and broke the build

2009-08-27 Thread Dave Korn
Eric Blake wrote: > Dave Korn googlemail.com> writes: > >> No problem, thanks for worrying about it. Are there any particular >> recommendations about/against problematic separator characters in the 's' >> command? I was going to use an '@'. > > The Autoconf manual suggests using 's|||' rath

Re: r150960 changed ltmain.sh and broke the build

2009-08-27 Thread Eric Blake
Dave Korn googlemail.com> writes: > No problem, thanks for worrying about it. Are there any particular > recommendations about/against problematic separator characters in the 's' > command? I was going to use an '@'. The Autoconf manual suggests using 's|||' rather than 's,,,', since ',' and

Re: r150960 changed ltmain.sh and broke the build

2009-08-26 Thread Dave Korn
Paolo Bonzini wrote: >>>Patterns should not include the separator (not even escaped, unless >>>you fancy having to use a semantically significant metacharacter for >>>your separator), even as part of a ... > > No. The problem is exactly when you use a semantically significant > metac

Re: r150960 changed ltmain.sh and broke the build

2009-08-26 Thread Paolo Bonzini
Patterns should not include the separator (unless escaped), even as part of a character class. In conformance with Posix, the Cray `sed' rejects `s/[^/]*$//': use `s,[^/]*$,,'. [...] Portable `sed' regular expressions should use `\' only to escape characters in the s

Re: r150960 changed ltmain.sh and broke the build

2009-08-26 Thread Ralf Wildenhues
[ trimmed Cc:, added autoconf-patches; followups can remove gcc@ ] [ http://thread.gmane.org/gmane.comp.gcc.devel/108348 ] * Dave Korn wrote on Wed, Aug 26, 2009 at 08:16:11PM CEST: > Ralf Wildenhues wrote: > > Patterns should not include the separator (unless escaped), even > > as part

Re: r150960 changed ltmain.sh and broke the build

2009-08-26 Thread Dave Korn
Ralf Wildenhues wrote: > * Dave Korn wrote on Wed, Aug 26, 2009 at 12:38:50PM CEST: >> Ralf, have we discovered a new item for the autoconf man page "portable >> shell" >> chapter? > > Not really: > > Patterns should not include the separator (unless escaped), even > as part of a char

Re: r150960 changed ltmain.sh and broke the build

2009-08-26 Thread Ralf Wildenhues
* Dave Korn wrote on Wed, Aug 26, 2009 at 12:38:50PM CEST: > Paolo Bonzini wrote: > > $ sed -e 's,/\(\./\)\{1\,\},/,g;s,/\.$,/,' > > ./foo/bar/./baz > > ./foo/bar/baz > > > > $ sed -e 's,/\(\./\)\{1,\},/,g;s,/\.$,/,' > > sed: -e expression #1, char 18: unknown option to `s' > > > > $ > > Maybe

Re: r150960 changed ltmain.sh and broke the build

2009-08-26 Thread Dave Korn
Paolo Bonzini wrote: > On 08/26/2009 12:48 PM, Dave Korn wrote: >> Dave Korn wrote: >> Also please single-quote the commands. >>> >>>Ok, why? >> >>BTW should I do that for all four of the patterns? And what about >> $dirname >> and $basename, and the couple of dozen other locations in

Re: r150960 changed ltmain.sh and broke the build

2009-08-26 Thread Paolo Bonzini
On 08/26/2009 12:48 PM, Dave Korn wrote: Dave Korn wrote: Also please single-quote the commands. Ok, why? BTW should I do that for all four of the patterns? And what about $dirname and $basename, and the couple of dozen other locations in ltmain.sh that use quoted sed scripts? (You

Re: r150960 changed ltmain.sh and broke the build

2009-08-26 Thread Dave Korn
Dave Korn wrote: >> Also please single-quote the commands. > > Ok, why? BTW should I do that for all four of the patterns? And what about $dirname and $basename, and the couple of dozen other locations in ltmain.sh that use quoted sed scripts? (You didn't answer my question about "why" yet

Re: r150960 changed ltmain.sh and broke the build

2009-08-26 Thread Paolo Bonzini
On 08/26/2009 12:38 PM, Dave Korn wrote: Oops. Looks like there are different versions of SED that have different requirements, because on cygwin SED 4.1.5, you*have* to quote the comma in the curly-braces {min,max} repetitions specifier or it is interpreted as a separator. Right. I also

Re: r150960 changed ltmain.sh and broke the build

2009-08-26 Thread Dave Korn
Paolo Bonzini wrote: >>Argh. Very sorry for the breakage, I'll get straight onto it. What >> versions of the mingw+msys tools are you using? Can you please send >> me a copy >> of the generated libtool script, and the output you get when >> re-running the >> failing libtool command manually

Re: r150960 changed ltmain.sh and broke the build

2009-08-26 Thread Paolo Bonzini
Argh. Very sorry for the breakage, I'll get straight onto it. What versions of the mingw+msys tools are you using? Can you please send me a copy of the generated libtool script, and the output you get when re-running the failing libtool command manually after adding the "--debug" (non-modal)

Re: r150960 changed ltmain.sh and broke the build

2009-08-26 Thread Dave Korn
NightStrike wrote: > Dave, > > You checked in r150960 here: > http://gcc.gnu.org/ml/gcc-cvs/2009-08/msg00642.html > > This change affected ltmain.sh: > http://gcc.gnu.org/viewcvs/trunk/ltmain.sh?r1=150960&r2=150959&pathrev=150960 > > All of those changes to sed now make sed fail miserably on any

r150960 changed ltmain.sh and broke the build

2009-08-26 Thread NightStrike
Dave, You checked in r150960 here: http://gcc.gnu.org/ml/gcc-cvs/2009-08/msg00642.html This change affected ltmain.sh: http://gcc.gnu.org/viewcvs/trunk/ltmain.sh?r1=150960&r2=150959&pathrev=150960 All of those changes to sed now make sed fail miserably on any mingw host during the build: libtoo