Re: just_select in combine.c:force_to_mode

2018-12-13 Thread Segher Boessenkool
On Fri, Dec 14, 2018 at 06:32:32AM +, senthilkumar.selva...@microchip.com wrote: > Segher Boessenkool writes: > > On Thu, Dec 13, 2018 at 09:39:52AM +, > > senthilkumar.selva...@microchip.com wrote: > >> When debugging PR 88253, I found that force_to_mode uses a parameter > >> (just_s

Re: just_select in combine.c:force_to_mode

2018-12-13 Thread SenthilKumar.Selvaraj
Segher Boessenkool writes: > Hi! > > On Thu, Dec 13, 2018 at 09:39:52AM +, senthilkumar.selva...@microchip.com > wrote: >> When debugging PR 88253, I found that force_to_mode uses a parameter >> (just_select) to prevent the function from returning a const0_rtx even >> if none of the b

Re: just_select in combine.c:force_to_mode

2018-12-13 Thread Segher Boessenkool
Hi! On Thu, Dec 13, 2018 at 09:39:52AM +, senthilkumar.selva...@microchip.com wrote: > When debugging PR 88253, I found that force_to_mode uses a parameter > (just_select) to prevent the function from returning a const0_rtx even > if none of the bits set by the rtx are needed. The comme

just_select in combine.c:force_to_mode

2018-12-13 Thread SenthilKumar.Selvaraj
Hi, When debugging PR 88253, I found that force_to_mode uses a parameter (just_select) to prevent the function from returning a const0_rtx even if none of the bits set by the rtx are needed. The comment says "If JUST_SELECT is nonzero, don't optimize by noticing that bits in MASK are