Re: get_range_query vs NULL argument

2023-02-17 Thread Andrew Pinski via Gcc
On Wed, Feb 15, 2023 at 2:30 PM Andrew MacLeod wrote: > > > On 2/15/23 14:50, Andrew Pinski wrote: > > Hi, > >While fixing PR 108354, I came across that > > ssa_name_has_boolean_range calls get_range_query with cfun as the > > argument but sometimes while in IPA passes cfun is currently nullpt

Re: get_range_query vs NULL argument

2023-02-16 Thread Aldy Hernandez via Gcc
On 2/16/23 08:57, Richard Biener wrote: On Wed, Feb 15, 2023 at 11:31 PM Andrew MacLeod via Gcc wrote: On 2/15/23 14:50, Andrew Pinski wrote: Hi, While fixing PR 108354, I came across that ssa_name_has_boolean_range calls get_range_query with cfun as the argument but sometimes while i

Re: get_range_query vs NULL argument

2023-02-15 Thread Richard Biener via Gcc
On Wed, Feb 15, 2023 at 11:31 PM Andrew MacLeod via Gcc wrote: > > > On 2/15/23 14:50, Andrew Pinski wrote: > > Hi, > >While fixing PR 108354, I came across that > > ssa_name_has_boolean_range calls get_range_query with cfun as the > > argument but sometimes while in IPA passes cfun is current

Re: get_range_query vs NULL argument

2023-02-15 Thread Andrew MacLeod via Gcc
On 2/15/23 14:50, Andrew Pinski wrote: Hi, While fixing PR 108354, I came across that ssa_name_has_boolean_range calls get_range_query with cfun as the argument but sometimes while in IPA passes cfun is currently nullptr. The question should we check the argument before calling get_range_que

get_range_query vs NULL argument

2023-02-15 Thread Andrew Pinski via Gcc
Hi, While fixing PR 108354, I came across that ssa_name_has_boolean_range calls get_range_query with cfun as the argument but sometimes while in IPA passes cfun is currently nullptr. The question should we check the argument before calling get_range_query or is it a valid thing to call it with a