Re: dg-skip-if was Re: gcc 4.3.0 i386 default question

2008-03-14 Thread Joseph S. Myers
On Fri, 14 Mar 2008, Paul Brook wrote: > I you have several of these you might want to consider adding an > effective-target check that uses a compile test rather than guessing from > commandline options. c.f. check_effective_target_arm32 and > check_effective_target_arm_vfp_ok. Note the issue

Re: dg-skip-if was Re: gcc 4.3.0 i386 default question

2008-03-14 Thread Janis Johnson
On Fri, 2008-03-14 at 10:21 -0700, Janis Johnson wrote: > On Fri, 2008-03-14 at 10:18 -0500, Joel Sherrill wrote: > > > /* { dg-skip-if "" { *-*-* } { "-mcpu=405" } { "-mcpu=" } } */ > > > > I think this is doing what we want it to. It looks like it results > > the tests getting run when -mcpu=40

Re: dg-skip-if was Re: gcc 4.3.0 i386 default question

2008-03-14 Thread Janis Johnson
On Fri, 2008-03-14 at 10:18 -0500, Joel Sherrill wrote: > /* { dg-skip-if "" { *-*-* } { "-mcpu=405" } { "-mcpu=" } } */ > > I think this is doing what we want it to. It looks like it results > the tests getting run when -mcpu=405 and excluded when > -mcpu=603e is set on the board cflags. The te

Re: dg-skip-if was Re: gcc 4.3.0 i386 default question

2008-03-14 Thread Joseph S. Myers
On Fri, 14 Mar 2008, Joel Sherrill wrote: > If you all think this is the right approach, ack me and I will > get the powerpc cases done first and submit a patch for review. Janis will need to confirm the right approach. The aim is: * If no -mcpu option in the multilib flags, run the test (with

Re: dg-skip-if was Re: gcc 4.3.0 i386 default question

2008-03-14 Thread Joel Sherrill
Joseph S. Myers wrote: On Thu, 13 Mar 2008, Joel Sherrill wrote: Also, if you use a multilib option in testing, that option goes on the command line *after* the options specified in dg-options. The tests may need to use dg-skip-if to skip them if any CPU option other than the one in the tes

Re: dg-skip-if was Re: gcc 4.3.0 i386 default question

2008-03-14 Thread Paul Brook
On Friday 14 March 2008, Joseph S. Myers wrote: > On Thu, 13 Mar 2008, Joel Sherrill wrote: > > > Also, if you use a multilib option in testing, that option goes on the > > > command line *after* the options specified in dg-options. The tests > > > may need to use dg-skip-if to skip them if any CP

Re: dg-skip-if was Re: gcc 4.3.0 i386 default question

2008-03-13 Thread Joseph S. Myers
On Thu, 13 Mar 2008, Joel Sherrill wrote: > > Also, if you use a multilib option in testing, that option goes on the > > command line *after* the options specified in dg-options. The tests may > > need to use dg-skip-if to skip them if any CPU option other than the one > > in the test is explicit

dg-skip-if was Re: gcc 4.3.0 i386 default question

2008-03-13 Thread Joel Sherrill
Joseph S. Myers wrote: On Wed, 12 Mar 2008, David Edelsohn wrote: Joel Sherrill writes: Joel> FAIL: gcc.target/powerpc/405-mullhw-1.c scan-assembler mullhw Joel> Are those things which would be expected to fail on a vanilla Joel> 603e target without networking or disk? Joel

Re: gcc 4.3.0 i386 default question

2008-03-12 Thread Joel Sherrill
Jan Hubicka wrote: David Edelsohn wrote: Joel Sherrill writes: Joel> Those all look like checks to see if the compiler itself Joel> supports Altivec -- not a run-time check on the hardware Joel> like the Neon check_effective_target_arm_neon_hw appears Joel> to be.

Re: gcc 4.3.0 i386 default question

2008-03-12 Thread Joel Sherrill
Joseph S. Myers wrote: On Wed, 12 Mar 2008, David Edelsohn wrote: Joel Sherrill writes: Joel> FAIL: gcc.target/powerpc/405-mullhw-1.c scan-assembler mullhw Joel> Are those things which would be expected to fail on a vanilla Joel> 603e target without networking or disk? Joel

Re: gcc 4.3.0 i386 default question

2008-03-12 Thread Joel Sherrill
David Edelsohn wrote: Joel Sherrill writes: Joel> Those all look like checks to see if the compiler itself Joel> supports Altivec -- not a run-time check on the hardware Joel> like the Neon check_effective_target_arm_neon_hw appears Joel> to be. Look at check_vmx_hw_availa

Re: gcc 4.3.0 i386 default question

2008-03-12 Thread Joseph S. Myers
On Wed, 12 Mar 2008, David Edelsohn wrote: > > Joel Sherrill writes: > > Joel> FAIL: gcc.target/powerpc/405-mullhw-1.c scan-assembler mullhw > > Joel> Are those things which would be expected to fail on a vanilla > Joel> 603e target without networking or disk? > > Joel> Is this another cate

Re: gcc 4.3.0 i386 default question

2008-03-12 Thread Jan Hubicka
> David Edelsohn wrote: > >>Joel Sherrill writes: > >> > > > >Joel> Those all look like checks to see if the compiler itself > >Joel> supports Altivec -- not a run-time check on the hardware > >Joel> like the Neon check_effective_target_arm_neon_hw appears > >Joel> to be. > > >

Re: gcc 4.3.0 i386 default question

2008-03-12 Thread David Edelsohn
> Joel Sherrill writes: Joel> FAIL: gcc.target/powerpc/405-mullhw-1.c scan-assembler mullhw Joel> Are those things which would be expected to fail on a vanilla Joel> 603e target without networking or disk? Joel> Is this another category of tests to avoid somehow? 405-mullhw-1.c is i

Re: gcc 4.3.0 i386 default question

2008-03-12 Thread Joel Sherrill
David Edelsohn wrote: Joel Sherrill writes: Joel> Those all look like checks to see if the compiler itself Joel> supports Altivec -- not a run-time check on the hardware Joel> like the Neon check_effective_target_arm_neon_hw appears Joel> to be. Look at check_vmx_hw_availa

Re: gcc 4.3.0 i386 default question

2008-03-12 Thread David Edelsohn
> Joel Sherrill writes: Joel> Those all look like checks to see if the compiler itself Joel> supports Altivec -- not a run-time check on the hardware Joel> like the Neon check_effective_target_arm_neon_hw appears Joel> to be. Look at check_vmx_hw_available again. David

Re: gcc 4.3.0 i386 default question

2008-03-12 Thread Paul Brook
On Wednesday 12 March 2008, Joel Sherrill wrote: > Paul Brook wrote: > >> Since we are talking 100s of tests, it seems like it would be > >> easiest to avoid them in the scripts. I just don't know how > >> to do that. > > > > You might want to look at how the ARM NEON vector unit is handled > > (ch

Re: gcc 4.3.0 i386 default question

2008-03-12 Thread Joel Sherrill
David Edelsohn wrote: Joel Sherrill writes: Joel> If I understand this correctly, it is checking that the Joel> target HW actually supports the Neon extension. Joel> Is this right? Joel> Where does this get invoked? Joel> I think I am on the edge of understanding a solution Joel>

Re: gcc 4.3.0 i386 default question

2008-03-12 Thread David Edelsohn
> Joel Sherrill writes: Joel> If I understand this correctly, it is checking that the Joel> target HW actually supports the Neon extension. Joel> Is this right? Joel> Where does this get invoked? Joel> I think I am on the edge of understanding a solution Joel> path. It sounds like I need to

Re: gcc 4.3.0 i386 default question

2008-03-12 Thread Joel Sherrill
Paul Brook wrote: Since we are talking 100s of tests, it seems like it would be easiest to avoid them in the scripts. I just don't know how to do that. You might want to look at how the ARM NEON vector unit is handled (check_effective_target_arm_neon_ok and check_effective_target_arm_neon_

Re: gcc 4.3.0 i386 default question

2008-03-12 Thread Paul Brook
> Since we are talking 100s of tests, it seems like it would be > easiest to avoid them in the scripts. I just don't know how > to do that. You might want to look at how the ARM NEON vector unit is handled (check_effective_target_arm_neon_ok and check_effective_target_arm_neon_hw). Paul

Re: gcc 4.3.0 i386 default question

2008-03-12 Thread Joel Sherrill
H.J. Lu wrote: On Wed, Mar 12, 2008 at 09:13:07AM -0700, Andrew Pinski wrote: On Wed, Mar 12, 2008 at 9:09 AM, Joel Sherrill <[EMAIL PROTECTED]> wrote: 10022a: f2 0f 10 c0 movsd %xmm0,%xmm0 Is there any way to skip these tests for particular HW features that are

Re: gcc 4.3.0 i386 default question

2008-03-12 Thread H.J. Lu
On Wed, Mar 12, 2008 at 09:13:07AM -0700, Andrew Pinski wrote: > On Wed, Mar 12, 2008 at 9:09 AM, Joel Sherrill > <[EMAIL PROTECTED]> wrote: > > > > > 10022a: f2 0f 10 c0 movsd %xmm0,%xmm0 > > > > Is there any way to skip these tests for particular HW features > > that are n

Re: gcc 4.3.0 i386 default question

2008-03-12 Thread Andrew Pinski
On Wed, Mar 12, 2008 at 9:09 AM, Joel Sherrill <[EMAIL PROTECTED]> wrote: > > 10022a: f2 0f 10 c0 movsd %xmm0,%xmm0 > > Is there any way to skip these tests for particular HW features > that are not present? There are similar failures on the PowerPC > target I use for repo

Re: gcc 4.3.0 i386 default question

2008-03-12 Thread Joel Sherrill
Richard Guenther wrote: On Wed, Mar 12, 2008 at 4:23 PM, Joel Sherrill <[EMAIL PROTECTED]> wrote: Hi, Did the default i386 CPU model that gcc generates code for change between 4.2.x and 4.3.0? I didn't see anything in the release notes that jumps out at me about this. Using i386-rtems

Re: gcc 4.3.0 i386 default question

2008-03-12 Thread Jan Hubicka
> Hi, > > Did the default i386 CPU model that gcc generates > code for change between 4.2.x and 4.3.0? I didn't > see anything in the release notes that jumps out at > me about this. There wasnt any intend to change the codebase. However the default tunning now has changed to "generic" model.

Re: gcc 4.3.0 i386 default question

2008-03-12 Thread Richard Guenther
On Wed, Mar 12, 2008 at 4:23 PM, Joel Sherrill <[EMAIL PROTECTED]> wrote: > Hi, > > Did the default i386 CPU model that gcc generates > code for change between 4.2.x and 4.3.0? I didn't > see anything in the release notes that jumps out at > me about this. > > Using i386-rtems4.9 as the targe

gcc 4.3.0 i386 default question

2008-03-12 Thread Joel Sherrill
Hi, Did the default i386 CPU model that gcc generates code for change between 4.2.x and 4.3.0? I didn't see anything in the release notes that jumps out at me about this. Using i386-rtems4.9 as the target, I was running code compiled by gcc 4.3.0 on a vanilla i386 and was getting illegal ins