Re: frv minmax predicate

2007-03-15 Thread DJ Delorie
> Ok. Thanks! Applied.

Re: frv minmax predicate

2007-03-15 Thread Aldy Hernandez
> "DJ" == DJ Delorie <[EMAIL PROTECTED]> writes: >> Oh, I get it now. No, there is no reason for the duplication between >> minmax_operator and the insn itself. You should be able to remove the >> tests from minmax_operator. I wonder why they are there at all? > This, then? Ok.

Re: frv minmax predicate

2007-03-15 Thread Ian Lance Taylor
DJ Delorie <[EMAIL PROTECTED]> writes: > 2007-03-15 DJ Delorie <[EMAIL PROTECTED]> > > * config/frv/predicates.md (minmax_operator): Don't check operands > here. Looks good to me. (Not that I know anything about the FRV). Ian

Re: frv minmax predicate

2007-03-15 Thread DJ Delorie
> Oh, I get it now. No, there is no reason for the duplication between > minmax_operator and the insn itself. You should be able to remove the > tests from minmax_operator. I wonder why they are there at all? This, then? 2007-03-15 DJ Delorie <[EMAIL PROTECTED]> * config/frv/predic

Re: frv minmax predicate

2007-03-15 Thread Ian Lance Taylor
DJ Delorie <[EMAIL PROTECTED]> writes: > > You just have to make sure that the predicate only accepts the types > > of operands the insn and constraints are prepared to handle. I would > > be a little bit skeptical of removing the gpr_or_int10_operand test, > > for example. But it would be reaso

Re: frv minmax predicate

2007-03-15 Thread DJ Delorie
> You just have to make sure that the predicate only accepts the types > of operands the insn and constraints are prepared to handle. I would > be a little bit skeptical of removing the gpr_or_int10_operand test, > for example. But it would be reasonable to check something else for a > floating

Re: frv minmax predicate

2007-03-15 Thread Ian Lance Taylor
DJ Delorie <[EMAIL PROTECTED]> writes: > The minmax_operator predicate also checks the operands of the operator > to be appropriate, but the minmax_operator predicate is used for both > integer and floating point operations. The predicate, as is, only > matches the integer operands. > > Taking o

frv minmax predicate

2007-03-15 Thread DJ Delorie
The minmax_operator predicate also checks the operands of the operator to be appropriate, but the minmax_operator predicate is used for both integer and floating point operations. The predicate, as is, only matches the integer operands. Taking out the check on XEXP(...) in minmax_operator seems