Re: fixed_scalar_and_varying_struct_p and varies_p

2012-01-26 Thread Richard Guenther
On Wed, Jan 25, 2012 at 8:20 PM, Richard Sandiford wrote: > Richard Guenther writes: >> I'd say open a missed optimization bug with the testcase and go ahead >> with both patches. > > OK, I committed the patches yesterday and I've just opened PR 52000 > for the missed optimisation. Btw, looking

Re: fixed_scalar_and_varying_struct_p and varies_p

2012-01-25 Thread Richard Sandiford
Richard Guenther writes: > I'd say open a missed optimization bug with the testcase and go ahead > with both patches. OK, I committed the patches yesterday and I've just opened PR 52000 for the missed optimisation. Richard

Re: fixed_scalar_and_varying_struct_p and varies_p

2012-01-24 Thread Richard Guenther
On Tue, Jan 24, 2012 at 4:51 PM, Richard Sandiford wrote: > Richard Guenther writes: >> On Mon, Jan 2, 2012 at 7:54 PM, Eric Botcazou wrote: I'd say open a missed optimization bug with the testcase and go ahead with both patches.  Let's see if Eric has some comments first though. >>> >

Re: fixed_scalar_and_varying_struct_p and varies_p

2012-01-24 Thread Richard Sandiford
Richard Guenther writes: > On Mon, Jan 2, 2012 at 7:54 PM, Eric Botcazou wrote: >>> I'd say open a missed optimization bug with the testcase and go ahead >>> with both patches.  Let's see if Eric has some comments first though. >> >> None, but the m32c maintainer may have some. >> >> DJ, do you h

Re: fixed_scalar_and_varying_struct_p and varies_p

2012-01-24 Thread Richard Guenther
On Mon, Jan 2, 2012 at 7:54 PM, Eric Botcazou wrote: >> I'd say open a missed optimization bug with the testcase and go ahead >> with both patches.  Let's see if Eric has some comments first though. > > None, but the m32c maintainer may have some. > > DJ, do you happen to know the rationale for th

Re: fixed_scalar_and_varying_struct_p and varies_p

2012-01-02 Thread Eric Botcazou
> I'd say open a missed optimization bug with the testcase and go ahead > with both patches. Let's see if Eric has some comments first though. None, but the m32c maintainer may have some. DJ, do you happen to know the rationale for the use of the MEM_SCALAR_P and MEM_IN_STRUCT_P flags in m32c_i

Re: fixed_scalar_and_varying_struct_p and varies_p

2012-01-02 Thread Richard Guenther
On Mon, Jan 2, 2012 at 3:42 PM, Richard Sandiford wrote: > Thanks for both replies. > > Richard Guenther writes: >> On Thu, Dec 29, 2011 at 8:48 PM, Eric Botcazou wrote: fixed_scalar_and_varying_struct_p passes an _address_ rather than a MEM. So in these cases fixed_scalar_and_varying_

Re: fixed_scalar_and_varying_struct_p and varies_p

2012-01-02 Thread Richard Sandiford
Thanks for both replies. Richard Guenther writes: > On Thu, Dec 29, 2011 at 8:48 PM, Eric Botcazou wrote: >>> fixed_scalar_and_varying_struct_p passes an _address_ rather than a MEM. >>> So in these cases fixed_scalar_and_varying_struct_p effectively becomes >>> a no-op on targets that don't all

Re: fixed_scalar_and_varying_struct_p and varies_p

2011-12-30 Thread Richard Guenther
On Thu, Dec 29, 2011 at 8:48 PM, Eric Botcazou wrote: >> fixed_scalar_and_varying_struct_p passes an _address_ rather than a MEM. >> So in these cases fixed_scalar_and_varying_struct_p effectively becomes >> a no-op on targets that don't allow MEMs in addresses and takes on >> suspicious semantics

Re: fixed_scalar_and_varying_struct_p and varies_p

2011-12-29 Thread Eric Botcazou
> fixed_scalar_and_varying_struct_p passes an _address_ rather than a MEM. > So in these cases fixed_scalar_and_varying_struct_p effectively becomes > a no-op on targets that don't allow MEMs in addresses and takes on > suspicious semantics for those that do. In the former case, every > address is

fixed_scalar_and_varying_struct_p and varies_p

2011-12-29 Thread Richard Sandiford
I was looking again at: http://gcc.gnu.org/ml/gcc-patches/2010-08/msg00294.html and was comparing the RTL {true,output,anti}_dependence functions. output_dependence and anti_dependence call fixed_scalar_and_varying_struct_p with rtx_addr_varies_p. Many places also call true_dependence with