Re: bootstrap broken on ppc-linux

2006-01-24 Thread Nathan Sidwell
Zack Weinberg wrote: This is close to obvious and should fix bootstrap, but I am hesitant to call anything about vec.h obvious. Nathan cc:ed. The vec patch looks ok. I see there's a duplicated line, + VEC_BASE (*vec_)->num = size_; \ + VEC_BASE (*vec_)

Re: bootstrap broken on ppc-linux

2006-01-23 Thread Zack Weinberg
On Mon, Jan 23, 2006 at 10:39:19PM +0100, Marcin Dalecki wrote: > > Inside genautomata.c there is a function gen_regexp_el(). It's > allocating > a regexp_t by calling create_node(). However the code looks like: > > else if (strcmp (str, NOTHING_NAME) == 0) > { > regexp = create_nod

Re: bootstrap broken on ppc-linux

2006-01-23 Thread Zack Weinberg
On Mon, Jan 23, 2006 at 03:46:10PM -0800, Richard Henderson wrote: > Got it. Looks good to me. (Argh, I thought I had caught all of the places where I made that mistake.) Are you going to check it in? And here's the fix for genautomata, which had two bugs. One was a simple case of assuming tha

Re: bootstrap broken on ppc-linux

2006-01-23 Thread Richard Henderson
Got it. r~ * genextract.c (VEC_safe_set_locstr): Take VEC by reference; update all callers. Index: genextract.c === --- genextract.c(revision 110129) +++ genextract.c(working copy) @@ -187,18 +187,

Re: bootstrap broken on ppc-linux

2006-01-23 Thread Marcin Dalecki
On 2006-01-23, at 21:36, Zack Weinberg wrote: Also, if you have access to valgrind (I can't remember if it works on x86-64 yet?) you could run both programs under it and report what it says, since this seems to be a bad-memory-access issue. Inside genautomata.c there is a function gen_re

Re: bootstrap broken on ppc-linux

2006-01-23 Thread Andrew Pinski
> Yes valgrind works on x86_64. > The output is not that huge, it is only 17k. > > Attached is the output. > > Thanks, > Andrew Pinski Here is the valgrind output for running genautomata, there was two failures. Thanks, Andrew Pinski ==21439== Memcheck, a memory error detector. ==21439== Copyri

Re: bootstrap broken on ppc-linux

2006-01-23 Thread Andrew Pinski
> > On Mon, Jan 23, 2006 at 03:28:59PM -0500, Andrew Pinski wrote: > > > > > > On Mon, Jan 23, 2006 at 03:16:56PM -0500, Andrew Pinski wrote: > > > > > > > > > > That's the genextract crash that rth is seeing on ppc-linux. Can you > > > > > also > > > > > reproduce the ppc-darwin genautomata c

Re: bootstrap broken on ppc-linux

2006-01-23 Thread Zack Weinberg
On Mon, Jan 23, 2006 at 03:28:59PM -0500, Andrew Pinski wrote: > > > > On Mon, Jan 23, 2006 at 03:16:56PM -0500, Andrew Pinski wrote: > > > > > > > > That's the genextract crash that rth is seeing on ppc-linux. Can you > > > > also > > > > reproduce the ppc-darwin genautomata crash? > > > > >

Re: bootstrap broken on ppc-linux

2006-01-23 Thread Andrew Pinski
> > On Mon, Jan 23, 2006 at 03:16:56PM -0500, Andrew Pinski wrote: > > > > > > That's the genextract crash that rth is seeing on ppc-linux. Can you also > > > reproduce the ppc-darwin genautomata crash? > > > > Nope. genautomata just works. > > Clarification please. In a cross configuration t

Re: bootstrap broken on ppc-linux

2006-01-23 Thread Zack Weinberg
On Mon, Jan 23, 2006 at 03:16:56PM -0500, Andrew Pinski wrote: > > > > That's the genextract crash that rth is seeing on ppc-linux. Can you also > > reproduce the ppc-darwin genautomata crash? > > Nope. genautomata just works. Clarification please. In a cross configuration targeting ppc-darwin

Re: bootstrap broken on ppc-linux

2006-01-23 Thread Andrew Pinski
> > On Mon, Jan 23, 2006 at 03:04:25PM -0500, Andrew Pinski wrote: > > > > > > On Mon, Jan 23, 2006 at 11:13:26AM -0800, Richard Henderson wrote: > > > > This is reproducible with an i686 cross. > > > > > > Urgh. And I've got Geert reporting a crash (in a different place) > > > on ppc-darwin. >

Re: bootstrap broken on ppc-linux

2006-01-23 Thread Zack Weinberg
On Mon, Jan 23, 2006 at 03:04:25PM -0500, Andrew Pinski wrote: > > > > On Mon, Jan 23, 2006 at 11:13:26AM -0800, Richard Henderson wrote: > > > This is reproducible with an i686 cross. > > > > Urgh. And I've got Geert reporting a crash (in a different place) > > on ppc-darwin. > > I was able to

Re: bootstrap broken on ppc-linux

2006-01-23 Thread Andrew Pinski
> > On Mon, Jan 23, 2006 at 11:13:26AM -0800, Richard Henderson wrote: > > This is reproducible with an i686 cross. > > Urgh. And I've got Geert reporting a crash (in a different place) > on ppc-darwin. I was able to reproduce the ppc-darwin failure with a cross compiler from x86_64-linux-gnu.

Re: bootstrap broken on ppc-linux

2006-01-23 Thread Zack Weinberg
On Mon, Jan 23, 2006 at 11:13:26AM -0800, Richard Henderson wrote: > This is reproducible with an i686 cross. Urgh. And I've got Geert reporting a crash (in a different place) on ppc-darwin. I won't be able to do anything until I get home, at 4 or 5 Pacific. If you/anyone feels like fixing it so

bootstrap broken on ppc-linux

2006-01-23 Thread Richard Henderson
This is reproducible with an i686 cross. build/genextract ../../src-head/gcc/config/rs6000/rs6000.md \ insn-conditions.md > tmp-extract.c *** glibc detected *** build/genextract: double free or corruption (fasttop): 0x081cc980 *** === Backtrace: = /lib/libc.so.6[0x9da124] /lib/libc.