Re: Unused DSE Functions

2012-11-25 Thread Richard Biener
On Tue, Nov 20, 2012 at 11:20 AM, Steven Bosscher wrote: > On Mon, 19 Nov 2012 18:31:27 -0800, Lawrence Crowl wrote: > >> Richi, ping? > > Just guessing... isn't he simply out on Honeymoon? > > Those functions were introduced to handle alias sets for spill slots > better, but IIRC this never worke

Re: Unused DSE Functions

2012-11-20 Thread Michael Matz
Hi, On Tue, 20 Nov 2012, Steven Bosscher wrote: > On Mon, 19 Nov 2012 18:31:27 -0800, Lawrence Crowl wrote: > > > Richi, ping? > > Just guessing... isn't he simply out on Honeymoon? Yes, he'll be back next week. Ciao, Michael.

Re: Unused DSE Functions

2012-11-20 Thread Steven Bosscher
On Mon, 19 Nov 2012 18:31:27 -0800, Lawrence Crowl wrote: > Richi, ping? Just guessing... isn't he simply out on Honeymoon? Those functions were introduced to handle alias sets for spill slots better, but IIRC this never worked properly. The whole path through dse_step2_spill is dead. The code

Re: Unused DSE Functions

2012-11-19 Thread Lawrence Crowl
On 11/12/12, Diego Novillo wrote: > On Mon, Nov 12, 2012 at 2:31 PM, Lawrence Crowl wrote: >> On 11/12/12, Lawrence Crowl wrote: >>> It appears that >>> >>> static bitmap clear_alias_sets = NULL; >>> >>> is never set, and as a consequence >>> >>> clear_alias_set_lookup (alias_set_type alias_

Re: Unused DSE Functions

2012-11-12 Thread Diego Novillo
On Mon, Nov 12, 2012 at 2:31 PM, Lawrence Crowl wrote: > On 11/12/12, Lawrence Crowl wrote: >> It appears that >> >> static bitmap clear_alias_sets = NULL; >> >> is never set, and as a consequence >> >> clear_alias_set_lookup (alias_set_type alias_set) >> >> is never called. This conclusion

Re: Unused DSE Functions

2012-11-12 Thread Lawrence Crowl
On 11/12/12, Lawrence Crowl wrote: > It appears that > > static bitmap clear_alias_sets = NULL; > > is never set, and as a consequence > > clear_alias_set_lookup (alias_set_type alias_set) > > is never called. This conclusion is reinforced because it > unconditionally uses htab_t clear_alias_

Unused DSE Functions

2012-11-12 Thread Lawrence Crowl
It appears that static bitmap clear_alias_sets = NULL; is never set, and as a consequence clear_alias_set_lookup (alias_set_type alias_set) is never called. This conclusion is reinforced because it unconditionally uses htab_t clear_alias_mode_table, which is never allocated. -- Lawrence