Re: Some real-life feedback on -Wmisleading-indentation

2016-01-12 Thread David Brown
On 11/01/16 08:20, Gerald Pfeifer wrote: Compiling Wine with GCC trunk (to become GCC 6) I noticed four dozen of warnings triggered by -Wmisleading-indentation. Some are simply weird formatting, some may be indicative of real issues -- and I have started to look into them one by one and submitti

Re: Some real-life feedback on -Wmisleading-indentation

2016-01-12 Thread Bernd Schmidt
On 01/12/2016 06:44 AM, Jeff Law wrote: I would argue that each of these does represent misleading indentation and that the warning is warranted for each. Perhaps they aren't as bad as prior cases, but I'd still consider them mis-leading. (https://gcc.gnu.org/ml/gcc-patches/2015-10/msg03242.html

Re: Some real-life feedback on -Wmisleading-indentation

2016-01-11 Thread Jeff Law
On 01/11/2016 07:53 AM, David Malcolm wrote: In Chapter 31 of "Code Complete" (I'm looking at the 2nd edition), McConnell discusses the use of whitespace in code layout; he talks about both blank lines and indentation as being useful for providing hints to the human reader about the structure o

Re: Some real-life feedback on -Wmisleading-indentation

2016-01-11 Thread Manuel López-Ibáñez
On 11/01/16 07:20, Gerald Pfeifer wrote: This is from the Wine testsuite, and the if (0) in colum one guards one invication of the function under test that would crash (so is the equivalent of #if 0...#endif, except that it avoids conditional compilation). Perhaps a good heuristic is to disable

Re: Some real-life feedback on -Wmisleading-indentation

2016-01-11 Thread David Malcolm
On Mon, 2016-01-11 at 15:20 +0800, Gerald Pfeifer wrote: > Compiling Wine with GCC trunk (to become GCC 6) I noticed four > dozen of warnings triggered by -Wmisleading-indentation. > > Some are simply weird formatting, some may be indicative of > real issues -- and I have started to look into the

Some real-life feedback on -Wmisleading-indentation

2016-01-10 Thread Gerald Pfeifer
Compiling Wine with GCC trunk (to become GCC 6) I noticed four dozen of warnings triggered by -Wmisleading-indentation. Some are simply weird formatting, some may be indicative of real issues -- and I have started to look into them one by one and submitting patches (to Wine). However, there is