Re: tuples: initial infrastructure

2007-04-23 Thread Aldy Hernandez
> > I figured > > it'd be better than doing GS_SEQP_FIRST(&non_pointer), but I can if you > > prefer. > > I think I would, though without the "P". Ok, everything fixed, except I haven't added the sequence iterators yet. I am committing the patch below to the gimple-tuples-branch. Thanks again.

Re: tuples: initial infrastructure

2007-04-23 Thread Richard Henderson
On Mon, Apr 23, 2007 at 04:30:40PM -0400, Aldy Hernandez wrote: > I figured > it'd be better than doing GS_SEQP_FIRST(&non_pointer), but I can if you > prefer. I think I would, though without the "P". r~

Re: tuples: initial infrastructure

2007-04-23 Thread Aldy Hernandez
> > +/* A sequences of gimple statements. */ > > +#define GS_SEQP_FIRST(S) (S)->first > > +#define GS_SEQP_LAST(S)(S)->last > > +#define GS_SEQ_FIRST(S)(S).first > > +#define GS_SEQ_LAST(S) (S).last > > Why do you have both of these? Most places in the gimpl

Re: tuples: initial infrastructure

2007-04-23 Thread Richard Henderson
On Fri, Apr 20, 2007 at 01:07:14PM -0400, Aldy Hernandez wrote: > + /* There can be 3 types of unary operations: > + > + SYM =<== GSS_ASSIGN_UNARY_REG > + SYM = SYM2 <== GSS_ASSIGN_UNARY_MEM Um, ssa_name = ssa_name isn't a memory > +/* A seq