On Mon, 2005-02-21 at 16:36 -0800, Mark Mitchell wrote:
> Jeffrey A Law wrote:
> > Sigh. I can't wait for this code to become less critical, both in terms
> > of runtime and compile time performance. There are so many things in
> > cse.c that are just plain bad
> >
> > cse.c has a fair amou
Jeffrey A Law wrote:
Sigh. I can't wait for this code to become less critical, both in terms
of runtime and compile time performance. There are so many things in
cse.c that are just plain bad
cse.c has a fair amount of complexity in its hash table management
code to avoid spending too much
On Mon, 2005-02-21 at 14:42 -0500, Kazu Hirata wrote:
> Hi Jeff,
>
> > The second thought is to initialize all of cse_reg_info entries at the
> > beginning of cse_main. Set aside a bitmap with as many bits as
> > max_regs. Whenever we use one of these accessor macros for register
> > k, set a bi
Hi Jeff,
> The second thought is to initialize all of cse_reg_info entries at the
> beginning of cse_main. Set aside a bitmap with as many bits as
> max_regs. Whenever we use one of these accessor macros for register
> k, set a bit k saying "cse_reg_info_table[k] is in use." This way,
> when we
On Mon, 2005-02-21 at 13:26 -0500, Kazu Hirata wrote:
> Hi Jeff,
>
> > Fixing cse.c to not use the accessor macros for REG_IN_TABLE, REG_TICK
> > and SUBREG_TICKED saves about 1% compilation time for the components
> > of cc1. Yes, that's a net 1% improvement by dropping the abstraction
> > layer
On Mon, 2005-02-21 at 19:05 +0100, Steven Bosscher wrote:
> On Feb 21, 2005 06:22 PM, Jeffrey A Law <[EMAIL PROTECTED]> wrote:
> > I realize that we are trying to write clean, easy to read code by using
> > a level of abstraction, but the abstraction is really getting in the
> > way of achieving re
Hi Jeff,
> Fixing cse.c to not use the accessor macros for REG_IN_TABLE, REG_TICK
> and SUBREG_TICKED saves about 1% compilation time for the components
> of cc1. Yes, that's a net 1% improvement by dropping the abstraction
> layer.
Yes, I've noticed the problem. In my defense, the code in ques
On Feb 21, 2005 06:22 PM, Jeffrey A Law <[EMAIL PROTECTED]> wrote:
> I realize that we are trying to write clean, easy to read code by using
> a level of abstraction, but the abstraction is really getting in the
> way of achieving reasonable compile-time performance.
I don't think this is a proble
