On Thu, Jun 23, 2011 at 22:04, Jason Merrill wrote:
> On 06/23/2011 06:48 PM, Ian Lance Taylor wrote:
>>
>> Well, so what? This test case does not represent actual or even likely
>> user code. I don't think we need to contort ourselves to generate all
>> possible errors for erroneous input. As
On 06/23/2011 06:48 PM, Ian Lance Taylor wrote:
Well, so what? This test case does not represent actual or even likely
user code. I don't think we need to contort ourselves to generate all
possible errors for erroneous input. As many errors as reasonable, yes.
All possible errors, no.
I agree
Diego Novillo writes:
> So, I think we need to re-think where to check for seen_errors().
> Bailing out too early is disabling some valid diagnostics. For
> instance,
>
> gcc/testsuite/gcc.dg/asm-7.c:
> $ cat -n
> /home/dnovillo/g1/fix-4487457/Patch-752f00bd28e325efdfa0ac7abed22feb_branches-goo
On Mon, Jun 20, 2011 at 10:50, Diego Novillo wrote:
> On Mon, Jun 20, 2011 at 10:47, Richard Guenther
> wrote:
>> On Fri, Jun 17, 2011 at 5:39 PM, Jason Merrill wrote:
>>>
>>> That seems reasonable to me.
>>
>> Yes. I think Steven proposed this as well at some point.
>
> Alright, thanks.
>
> Un
On Mon, Jun 20, 2011 at 10:47, Richard Guenther
wrote:
> On Fri, Jun 17, 2011 at 5:39 PM, Jason Merrill wrote:
>>
>> That seems reasonable to me.
>
> Yes. I think Steven proposed this as well at some point.
Alright, thanks.
Unsurprisingly, this produces 152 failures in the testsuite. I have
n
On Fri, Jun 17, 2011 at 5:39 PM, Jason Merrill wrote:
> On 06/17/2011 10:55 AM, Diego Novillo wrote:
>>
>> On Fri, Jun 17, 2011 at 14:47, Diego Novillo wrote:
>>
>>> if (flag_syntax_only || flag_wpa)
>>> return;
>>>
>>> to
>>>
>>> if (flag_syntax_only || flag_wpa || errorcount> 0)
>>> retur
On 06/17/2011 10:55 AM, Diego Novillo wrote:
On Fri, Jun 17, 2011 at 14:47, Diego Novillo wrote:
if (flag_syntax_only || flag_wpa)
return;
to
if (flag_syntax_only || flag_wpa || errorcount> 0)
return;
To clarify. It would be 'seen_error ()' instead of 'errorcount> 0',
but the id
On Fri, Jun 17, 2011 at 14:47, Diego Novillo wrote:
> if (flag_syntax_only || flag_wpa)
> return;
>
> to
>
> if (flag_syntax_only || flag_wpa || errorcount > 0)
> return;
To clarify. It would be 'seen_error ()' instead of 'errorcount > 0',
but the idea is the same.
Diego.
