Re: [PING^2] Re: Fix 'hash_table::expand' to destruct stale Value objects

2021-09-20 Thread Richard Biener via Gcc
On Fri, Sep 17, 2021 at 5:52 PM Thomas Schwinge wrote: > > Hi! > > On 2021-09-17T15:03:18+0200, Richard Biener > wrote: > > On Fri, Sep 17, 2021 at 2:39 PM Jonathan Wakely > > wrote: > >> On Fri, 17 Sept 2021 at 13:08, Richard Biener > >> wrote: > >> > On Fri, Sep 17, 2021 at 1:17 PM Thomas S

Re: [PING^2] Re: Fix 'hash_table::expand' to destruct stale Value objects

2021-09-17 Thread Jonathan Wakely via Gcc
On Fri, 17 Sep 2021, 16:52 Thomas Schwinge, wrote: > Hi! > > On 2021-09-17T15:03:18+0200, Richard Biener > wrote: > > On Fri, Sep 17, 2021 at 2:39 PM Jonathan Wakely > wrote: > >> On Fri, 17 Sept 2021 at 13:08, Richard Biener > >> wrote: > >> > On Fri, Sep 17, 2021 at 1:17 PM Thomas Schwinge <

Re: [PING^2] Re: Fix 'hash_table::expand' to destruct stale Value objects

2021-09-17 Thread Thomas Schwinge
Hi! On 2021-09-17T15:03:18+0200, Richard Biener wrote: > On Fri, Sep 17, 2021 at 2:39 PM Jonathan Wakely wrote: >> On Fri, 17 Sept 2021 at 13:08, Richard Biener >> wrote: >> > On Fri, Sep 17, 2021 at 1:17 PM Thomas Schwinge >> > wrote: >> > > On 2021-09-10T10:00:25+0200, I wrote: >> > > > On

Re: [PING^2] Re: Fix 'hash_table::expand' to destruct stale Value objects

2021-09-17 Thread Richard Biener via Gcc
On Fri, Sep 17, 2021 at 2:39 PM Jonathan Wakely wrote: > > On Fri, 17 Sept 2021 at 13:08, Richard Biener > wrote: > > > > On Fri, Sep 17, 2021 at 1:17 PM Thomas Schwinge > > wrote: > > > > > > Hi! > > > > > > On 2021-09-10T10:00:25+0200, I wrote: > > > > On 2021-09-01T19:31:19-0600, Martin Sebo

Re: [PING^2] Re: Fix 'hash_table::expand' to destruct stale Value objects

2021-09-17 Thread Jonathan Wakely via Gcc
On Fri, 17 Sept 2021 at 13:08, Richard Biener wrote: > > On Fri, Sep 17, 2021 at 1:17 PM Thomas Schwinge > wrote: > > > > Hi! > > > > On 2021-09-10T10:00:25+0200, I wrote: > > > On 2021-09-01T19:31:19-0600, Martin Sebor via Gcc-patches > > > wrote: > > >> On 8/30/21 4:46 AM, Thomas Schwinge wr

Re: [PING^2] Re: Fix 'hash_table::expand' to destruct stale Value objects

2021-09-17 Thread Richard Biener via Gcc
On Fri, Sep 17, 2021 at 1:17 PM Thomas Schwinge wrote: > > Hi! > > On 2021-09-10T10:00:25+0200, I wrote: > > On 2021-09-01T19:31:19-0600, Martin Sebor via Gcc-patches > > wrote: > >> On 8/30/21 4:46 AM, Thomas Schwinge wrote: > >>> Ping -- we still need to plug the memory leak; see patch attache

[PING^2] Re: Fix 'hash_table::expand' to destruct stale Value objects

2021-09-17 Thread Thomas Schwinge
Hi! On 2021-09-10T10:00:25+0200, I wrote: > On 2021-09-01T19:31:19-0600, Martin Sebor via Gcc-patches > wrote: >> On 8/30/21 4:46 AM, Thomas Schwinge wrote: >>> Ping -- we still need to plug the memory leak; see patch attached, and/or >>> long discussion here: >> >> Thanks for answering my quest

[PING] Re: Fix 'hash_table::expand' to destruct stale Value objects

2021-09-10 Thread Thomas Schwinge
Hi! On 2021-09-01T19:31:19-0600, Martin Sebor via Gcc-patches wrote: > On 8/30/21 4:46 AM, Thomas Schwinge wrote: >> Ping -- we still need to plug the memory leak; see patch attached, and/or >> long discussion here: > > Thanks for answering my questions. I have no concerns with going > forward

Re: Fix 'hash_table::expand' to destruct stale Value objects

2021-09-01 Thread Martin Sebor via Gcc
On 8/30/21 4:46 AM, Thomas Schwinge wrote: Hi! Ping -- we still need to plug the memory leak; see patch attached, and/or long discussion here: Thanks for answering my questions. I have no concerns with going forward with the patch as is. Just a suggestion/request: unless this patch fixes all