Re: Dead Field Elimination and Field Reordering

2020-11-11 Thread Erick Ochoa
Hello, I will be posting today some changes on the patches mailing list. I believe that due to some changes in the way clones are materialized, the transformation now supports IPA-SRA by default. I still need to test this more thoroughly, but initial tests show that this is no longer an issue

Re: Dead Field Elimination and Field Reordering

2020-11-06 Thread Erick Ochoa
Hi Richard, just some top-level comments before I write about anything specific: * I have removed all non-essential flags I introduced * I have placed the standard headers before config * I have squashed some changes that I sent to the patches mailing list and make sure that the transformation

Re: Dead Field Elimination and Field Reordering

2020-11-05 Thread Richard Biener via Gcc
On Tue, Nov 3, 2020 at 5:21 PM Erick Ochoa wrote: > > Thanks for the review Richard I'll address what I can. I also provide > maybe some hindsight into some of the design decisions here. I'm not > trying to be defensive just hoping to illuminate why some decisions were > made and how some criticis

Re: Dead Field Elimination and Field Reordering

2020-11-03 Thread Erick Ochoa
Thanks for the review Richard I'll address what I can. I also provide maybe some hindsight into some of the design decisions here. I'm not trying to be defensive just hoping to illuminate why some decisions were made and how some criticisms may fail to really address the reason why these design

Re: Dead Field Elimination and Field Reordering

2020-11-03 Thread Richard Biener via Gcc
On Fri, Oct 30, 2020 at 6:44 PM Erick Ochoa wrote: > > Hello again, > > I've been working on several implementations of data layout > optimizations for GCC, and I am again kindly requesting for a review of > the type escape based dead field elimination and field reorg. > > Thanks to everyone that