Re: Bad indentation and strange code in fortran/trans-array.c

2006-02-01 Thread Paul Thomas
H. J. Lu wrote: On Thu, Feb 02, 2006 at 12:39:41AM +0100, Paul Thomas wrote: H. J This regtests OK and simplifies things somewhat: What is this format? I don't think I can apply it cleanly? I am not surprised - I tried to cut and paste from a large patch that I am working on.

Re: Bad indentation and strange code in fortran/trans-array.c

2006-02-01 Thread H. J. Lu
On Thu, Feb 02, 2006 at 12:39:41AM +0100, Paul Thomas wrote: > H. J > > This regtests OK and simplifies things somewhat: > What is this format? I don't think I can apply it cleanly? H.J. --- > Index: gcc/fortran/trans-array.c > ==

Re: Bad indentation and strange code in fortran/trans-array.c

2006-02-01 Thread Paul Thomas
H. J This regtests OK and simplifies things somewhat: Index: gcc/fortran/trans-array.c === *** gcc/fortran/trans-array.c (revision 110407) --- gcc/fortran/trans-array.c (working copy) *** gfc_conv_expr_descriptor (gfc_se

Re: Bad indentation and strange code in fortran/trans-array.c

2006-01-31 Thread Paul Thomas
H. J, <>Also why are there duplicated On the face of , that is very odd. It looks as if the charlen_ is obtained, the type obtained and the charlen done over again. I will have a look today. Thanks Paul

Re: Bad indentation and strange code in fortran/trans-array.c

2006-01-31 Thread H. J. Lu
On Tue, Jan 31, 2006 at 06:03:12PM -0800, Steve Kargl wrote: > On Tue, Jan 31, 2006 at 05:57:04PM -0800, H. J. Lu wrote: > > Around line 3923 in fortran/trans-array.c, there are > > > > if (expr->ts.type == BT_CHARACTER) > > { > > gcc_assert (expr->ts.cl && expr->ts.cl->len

Re: Bad indentation and strange code in fortran/trans-array.c

2006-01-31 Thread Steve Kargl
On Tue, Jan 31, 2006 at 05:57:04PM -0800, H. J. Lu wrote: > Around line 3923 in fortran/trans-array.c, there are > > if (expr->ts.type == BT_CHARACTER) > { > gcc_assert (expr->ts.cl && expr->ts.cl->length > && expr->ts.cl->length->expr_type == EXPR_CON