Re: Backporting to 4_0 the latest friend bits

2005-05-20 Thread Mark Mitchell
Paolo Carlini wrote: Mark Mitchell wrote: OK, please go ahead and apply the relevant patch -- once we are out of the slush. Thanks a lot Mark. To be sure: in my understanding, only mainline is in slush, not 4_0-branch, where we want to backport the patches. If I'm mistaken please let us know ASAP

Re: Backporting to 4_0 the latest friend bits

2005-05-20 Thread Paolo Carlini
Mark Mitchell wrote: > OK, please go ahead and apply the relevant patch -- once we are out of > the slush. Thanks a lot Mark. To be sure: in my understanding, only mainline is in slush, not 4_0-branch, where we want to backport the patches. If I'm mistaken please let us know ASAP. Paolo.

Re: Backporting to 4_0 the latest friend bits

2005-05-19 Thread Mark Mitchell
Kriang Lerdsuwanakij wrote: Mark Mitchell wrote: OK. Do you happen to have access to any other testsuites, beyond the GCC testsuite? If so, it would be great to validate the behavior of the compiler on the 4.0 branch with and without your patch to make sure that we're not doing any harm. I a

Re: Backporting to 4_0 the latest friend bits

2005-05-16 Thread Kriang Lerdsuwanakij
Mark Mitchell wrote: OK. Do you happen to have access to any other testsuites, beyond the GCC testsuite? If so, it would be great to validate the behavior of the compiler on the 4.0 branch with and without your patch to make sure that we're not doing any harm. I am sorry I don't have it. --Kr

Re: Backporting to 4_0 the latest friend bits

2005-05-15 Thread Mark Mitchell
Kriang Lerdsuwanakij wrote: I see that either the patch (actually only one of the two fixes this issue: http://gcc.gnu.org/ml/gcc-patches/2005-03/msg01283.html ) applied or leave the current behavior as is. It would do more harm than good if we try to do something different. OK. Do you happen to

Re: Backporting to 4_0 the latest friend bits

2005-05-07 Thread Kriang Lerdsuwanakij
Mark Mitchell wrote: Those are somewhat above my pain threshold. Is there something else that we could do for the 4.0 branch? Like issue a warning and ignore the friend declaration? Sorry for long delay. I just got back from a trip (but I will be away next week as well.) Doing what you sugg

Re: Backporting to 4_0 the latest friend bits

2005-05-03 Thread Michael Matz
Hi, On Mon, 2 May 2005, Mark Mitchell wrote: > At the same time, if the code in question doesn't mean what the person > who wrote it wants it to mean (e.g., if it implicitly declares classes > in the scope of the friendly class, rather than nominating other classes > as friends), then that code s

Re: Backporting to 4_0 the latest friend bits

2005-05-02 Thread Mark Mitchell
Paolo Carlini wrote: Hi Mark, I agree; that's why I asked to see the patches. Humm, maybe a couple of links are in order, for your convenience: http://gcc.gnu.org/ml/gcc-cvs/2005-03/msg00681.html http://gcc.gnu.org/ml/gcc-cvs/2005-03/msg00679.html (I understand that Kriang volunteered to

Re: Backporting to 4_0 the latest friend bits

2005-05-02 Thread Paolo Carlini
Hi Mark, > I agree; that's why I asked to see the patches. Humm, maybe a couple of links are in order, for your convenience: http://gcc.gnu.org/ml/gcc-cvs/2005-03/msg00681.html http://gcc.gnu.org/ml/gcc-cvs/2005-03/msg00679.html (I understand that Kriang volunteered to regtest and, if n

Re: Backporting to 4_0 the latest friend bits

2005-05-02 Thread Mark Mitchell
Michael Matz wrote: Hi, On Sat, 30 Apr 2005, Kriang Lerdsuwanakij wrote: Sure, this code compiles with 4.1 and 3.4 but doesn't compile with 4.0. Although the code is valid, I'd bet it doesn't work the way the programmer of the above code (or other 99% who doesn't track the standard closely) would

Re: Backporting to 4_0 the latest friend bits

2005-05-02 Thread Michael Matz
Hi, On Sat, 30 Apr 2005, Kriang Lerdsuwanakij wrote: > Sure, this code compiles with 4.1 and 3.4 but doesn't compile with 4.0. > Although the code is valid, I'd bet it doesn't work the way the > programmer of the above code (or other 99% who doesn't track > the standard closely) would expect. No

Re: Backporting to 4_0 the latest friend bits

2005-04-30 Thread Kriang Lerdsuwanakij
Joe Buck wrote: >I don't quite understand your answer. It seems that (a) is the important >issue; if the programs are valid, they compiled before, and they worked >before, then it seems there really is a regression, even if we can argue >that we were "right by accident" in the past. > This is a

Re: Backporting to 4_0 the latest friend bits

2005-04-29 Thread Paolo Carlini
Joe Buck wrote: >>Thanks for your assessment of the problem: indeed, I can tell you for >>sure that (b) it's true and, as reported by Kriang, the patches are >>rather simple (but the details of this judgement are up to you, of >>course). I'm not 100% sure about (a) but Michael can tell you better:

Re: Backporting to 4_0 the latest friend bits

2005-04-29 Thread Joe Buck
On Fri, Apr 29, 2005 at 10:12:46PM +0200, Paolo Carlini wrote: > >> I know that, technically, we are not talking about regressions wrt > >> 3.x, still, important packages that used to compile and, well, > >> apparently at least, *work* well, now don't even compile (see > >> c++/19403, c++/21235, ma

Re: Backporting to 4_0 the latest friend bits

2005-04-29 Thread Paolo Carlini
Hi Mark, >> I know that, technically, we are not talking about regressions wrt >> 3.x, still, important packages that used to compile and, well, >> apparently at least, *work* well, now don't even compile (see >> c++/19403, c++/21235, many others linked from there). Would be a big >> deal having m

Re: Backporting to 4_0 the latest friend bits

2005-04-29 Thread Mark Mitchell
Paolo Carlini wrote: Hi Kriang and Mark, [ friend PRs snipped ] I know that, technically, we are not talking about regressions wrt 3.x, still, important packages that used to compile and, well, apparently at least, *work* well, now don't even compile (see c++/19403, c++/21235, many others linked fr

Re: Backporting to 4_0 the latest friend bits

2005-04-29 Thread Andrew Pinski
On Apr 29, 2005, at 3:40 PM, Paolo Carlini wrote: Hi Kriang and Mark, I know that, technically, we are not talking about regressions wrt 3.x, still, important packages that used to compile and, well, apparently at least, *work* well, now don't even compile (see c++/19403, c++/21235, many others