Re: A question on ACX_BUGURL

2007-03-26 Thread Paolo Bonzini
H. J. Lu wrote: > On Mon, Mar 26, 2007 at 09:13:30AM +0200, Paolo Bonzini wrote: >> Please do this instead: >> >> [EMAIL PROTECTED] "$BUGURL" | sed 's/@/@@/g'`} >> > > Will it work with spaces in $BUGURL? Yes, it will. You need quoting in the echo command, but not in the variable assignment.

Re: A question on ACX_BUGURL

2007-03-26 Thread H. J. Lu
On Mon, Mar 26, 2007 at 09:13:30AM +0200, Paolo Bonzini wrote: > Please do this instead: > > [EMAIL PROTECTED] "$BUGURL" | sed 's/@/@@/g'`} > Will it work with spaces in $BUGURL? H.J.

Re: A question on ACX_BUGURL

2007-03-26 Thread Paolo Bonzini
Andreas Schwab wrote: > Paolo Bonzini <[EMAIL PROTECTED]> writes: > >>> + no) BUGURL=""; >> just BUGURL= (no useless trailing semicolon). >> >>> + case ${BUGURL} in >> Please quote this as "$BUGURL". > > That would be useless quotes. :-) Uh, you're right. Word split does not apply in a c

Re: A question on ACX_BUGURL

2007-03-26 Thread Andreas Schwab
Paolo Bonzini <[EMAIL PROTECTED]> writes: >> + no) BUGURL=""; > > just BUGURL= (no useless trailing semicolon). > >> + case ${BUGURL} in > > Please quote this as "$BUGURL". That would be useless quotes. :-) Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products Gmb

Re: A question on ACX_BUGURL

2007-03-25 Thread Paolo Bonzini
> + no) BUGURL=""; just BUGURL= (no useless trailing semicolon). > + case ${BUGURL} in Please quote this as "$BUGURL". > +REPORT_BUGS_TO="<$BUGURL>" > +REPORT_BUGS_TEXI="@uref{`echo $BUGURL | sed 's/@/@@/g'`}" Please do this instead: [EMAIL PROTECTED] "$BUGURL" | sed 's/@/@@/

Re: A question on ACX_BUGURL

2007-03-23 Thread H. J. Lu
On Fri, Mar 23, 2007 at 06:20:10PM -, Dave Korn wrote: > On 23 March 2007 18:11, H. J. Lu wrote: > > > On Fri, Mar 23, 2007 at 06:55:38PM +0100, Andreas Schwab wrote: > >> "H. J. Lu" <[EMAIL PROTECTED]> writes: > >> > >>> REPORT_BUGS_TO="<$1>" > >>> - REPORT_BUGS_TEXI="@uref{$1}" >

RE: A question on ACX_BUGURL

2007-03-23 Thread Dave Korn
On 23 March 2007 18:11, H. J. Lu wrote: > On Fri, Mar 23, 2007 at 06:55:38PM +0100, Andreas Schwab wrote: >> "H. J. Lu" <[EMAIL PROTECTED]> writes: >> >>> REPORT_BUGS_TO="<$1>" >>> - REPORT_BUGS_TEXI="@uref{$1}" >>> + REPORT_BUGS_TEXI="@uref{`echo $1 | sed 's/@/@@/g'`}" >> >> You n

Re: A question on ACX_BUGURL

2007-03-23 Thread H. J. Lu
On Fri, Mar 23, 2007 at 06:55:38PM +0100, Andreas Schwab wrote: > "H. J. Lu" <[EMAIL PROTECTED]> writes: > > > REPORT_BUGS_TO="<$1>" > > - REPORT_BUGS_TEXI="@uref{$1}" > > + REPORT_BUGS_TEXI="@uref{`echo $1 | sed 's/@/@@/g'`}" > > You need to quote $1. I treated it the same as REP

Re: A question on ACX_BUGURL

2007-03-23 Thread Andreas Schwab
"H. J. Lu" <[EMAIL PROTECTED]> writes: > REPORT_BUGS_TO="<$1>" > - REPORT_BUGS_TEXI="@uref{$1}" > + REPORT_BUGS_TEXI="@uref{`echo $1 | sed 's/@/@@/g'`}" You need to quote $1. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409

Re: A question on ACX_BUGURL

2007-03-23 Thread H. J. Lu
On Fri, Mar 23, 2007 at 04:57:03PM +, Joseph S. Myers wrote: > On Fri, 23 Mar 2007, H. J. Lu wrote: > > > It assumes there is no @ in $1. Shouldn't be > > > > REPORT_BUGS_TEXI="@uref{`echo $1 | sed 's/@/@@/g'`}" > > Feel free to refine it. It's just there are about three possible users

Re: A question on ACX_BUGURL

2007-03-23 Thread Joseph S. Myers
On Fri, 23 Mar 2007, H. J. Lu wrote: > It assumes there is no @ in $1. Shouldn't be > > REPORT_BUGS_TEXI="@uref{`echo $1 | sed 's/@/@@/g'`}" Feel free to refine it. It's just there are about three possible users of these macros in the GCC and src trees and I expected them all to wish to

Re: A question on ACX_BUGURL

2007-03-23 Thread Paolo Bonzini
> It assumes there is no @ in $1. Shouldn't be > > REPORT_BUGS_TEXI="@uref{`echo $1 | sed 's/@/@@/g'`}" Seems fair, but please check all the users, they might be escaping the value already. Paolo