Re: [debug-early] LTO streaming of on-the-side dwarf data structures

2014-10-15 Thread Aldy Hernandez
On 10/15/14 00:55, Richard Biener wrote: On Tue, Oct 14, 2014 at 10:07 PM, Aldy Hernandez wrote: On 10/14/14 06:21, Richard Biener wrote: On Tue, Oct 14, 2014 at 2:48 AM, Aldy Hernandez wrote: Another similar issue I've seen is handling DW_TAG_lexical_block (gen_lexical_block_die). Ideal

Re: [debug-early] LTO streaming of on-the-side dwarf data structures

2014-10-15 Thread Richard Biener
On Tue, Oct 14, 2014 at 10:32 PM, Aldy Hernandez wrote: > >> Another similar issue I've seen is handling DW_TAG_lexical_block >> (gen_lexical_block_die). Ideally we should generate the >> DW_TAG_lexical_block and the corresponding locals in early dumping, and >> then fill in the high/low attribut

Re: [debug-early] LTO streaming of on-the-side dwarf data structures

2014-10-15 Thread Richard Biener
On Tue, Oct 14, 2014 at 10:07 PM, Aldy Hernandez wrote: > On 10/14/14 06:21, Richard Biener wrote: >> >> On Tue, Oct 14, 2014 at 2:48 AM, Aldy Hernandez wrote: >>> >>> Gentlemen, your feedback would be greatly appreciated! >>> >>> I was investigating why locals were not being early dumped, and re

Re: [debug-early] LTO streaming of on-the-side dwarf data structures

2014-10-14 Thread Aldy Hernandez
Another similar issue I've seen is handling DW_TAG_lexical_block (gen_lexical_block_die). Ideally we should generate the DW_TAG_lexical_block and the corresponding locals in early dumping, and then fill in the high/low attributes of the lexical block the second time around. We would need a has

Re: [debug-early] LTO streaming of on-the-side dwarf data structures

2014-10-14 Thread Aldy Hernandez
On 10/14/14 06:21, Richard Biener wrote: On Tue, Oct 14, 2014 at 2:48 AM, Aldy Hernandez wrote: Gentlemen, your feedback would be greatly appreciated! I was investigating why locals were not being early dumped, and realized Michael's patch was skipping decls_for_scope() unless DECL_STRUCT_FUNC

Re: [debug-early] LTO streaming of on-the-side dwarf data structures

2014-10-14 Thread Richard Biener
On Tue, Oct 14, 2014 at 2:48 AM, Aldy Hernandez wrote: > Gentlemen, your feedback would be greatly appreciated! > > I was investigating why locals were not being early dumped, and realized > Michael's patch was skipping decls_for_scope() unless > DECL_STRUCT_FUNCTION->gimple_df was set. I assume