Re: [RFC] warning: initialization discards qualifiers from pointer target type

2005-04-19 Thread Devang Patel
On Apr 19, 2005, at 11:51 AM, James E Wilson wrote: Devang Patel wrote: On Apr 18, 2005, at 6:29 PM, James E Wilson wrote: I notice that these are pedwarns, In that case, we can enable it only when -pedantic is used (like many pedwarns) ? Consider this small modification to your testcase. const

Re: [RFC] warning: initialization discards qualifiers from pointer target type

2005-04-19 Thread James E Wilson
Devang Patel wrote: On Apr 18, 2005, at 6:29 PM, James E Wilson wrote: I notice that these are pedwarns, In that case, we can enable it only when -pedantic is used (like many pedwarns) ? Consider this small modification to your testcase. const char *a( void ) { return "abc"; } int main( void )

Re: [RFC] warning: initialization discards qualifiers from pointer target type

2005-04-19 Thread Devang Patel
On Apr 18, 2005, at 9:22 PM, Eric Christopher wrote: Though of course, this doesn't mean that we can't have an option to control it. -Wno-cast-qual doesn't seem like the right choice, as there is no user cast here. Maybe something like -Wno-discard- qual, where -Wdiscard-qual is the default. I no

Re: [RFC] warning: initialization discards qualifiers from pointer target type

2005-04-18 Thread Eric Christopher
> > > > Though of course, this doesn't mean that we can't have an option to > > control it. -Wno-cast-qual doesn't seem like the right choice, as > > there is no user cast here. Maybe something like -Wno-discard- > > qual, where -Wdiscard-qual is the default. > > > > I notice that these are

Re: [RFC] warning: initialization discards qualifiers from pointer target type

2005-04-18 Thread Devang Patel
On Apr 18, 2005, at 6:29 PM, James E Wilson wrote: Devang Patel wrote: warning: initialization discards qualifiers from pointer target type This warning can not be disabled using -Wno-cast-qual (or any other warning flags). Is it intentional ? It looks like we have been doing it this way sin

Re: [RFC] warning: initialization discards qualifiers from pointer target type

2005-04-18 Thread Mike Stump
On Apr 18, 2005, at 6:29 PM, James E Wilson wrote: This seems rather unlikely to be an accident. I agree, I'm sure it was due to bad system header files, only some of which had const and others didn't. By ignoring the issue in the compiler, the compiler works on such (broken) systems. The usu

Re: [RFC] warning: initialization discards qualifiers from pointer target type

2005-04-18 Thread James E Wilson
Devang Patel wrote: warning: initialization discards qualifiers from pointer target type This warning can not be disabled using -Wno-cast-qual (or any other warning flags). Is it intentional ? It looks like we have been doing it this way since at least gcc-1.42. The same code is there, with n