Re: [RFC] enabling -fshow-column by default

2009-06-11 Thread Jonathan Wakely
2009/6/11 Aldy Hernandez: > > In the meantime, can you just put the column number in the dg-error > message?  i.e: > >        // { dg-error "XX:no match" } > > This will match the message correctly, and eventually all error messages > should have matching columns. That works great, thanks, Aldy.

Re: [RFC] enabling -fshow-column by default

2009-06-11 Thread Aldy Hernandez
On Thu, Jun 11, 2009 at 03:09:48PM +0100, Jonathan Wakely wrote: > 2009/6/5 Jonathan Wakely: > > 2009/6/5 Aldy Hernandez: > >> > >> Which test is this? ?Can you send it to me? > > > > It tests a header that isn't checked in yet, so sending the test alone > > wouldn't help much :) > > > > I'll try t

Re: [RFC] enabling -fshow-column by default

2009-06-11 Thread Jonathan Wakely
2009/6/5 Jonathan Wakely: > 2009/6/5 Aldy Hernandez: >> >> Which test is this?  Can you send it to me? > > It tests a header that isn't checked in yet, so sending the test alone > wouldn't help much :) > > I'll try to come up with a self-contained example tomorrow. The attached test will FAIL with

Re: [RFC] enabling -fshow-column by default

2009-06-05 Thread Jonathan Wakely
2009/6/5 Aldy Hernandez: > > Which test is this? Can you send it to me? It tests a header that isn't checked in yet, so sending the test alone wouldn't help much :) I'll try to come up with a self-contained example tomorrow. Jonathan

Re: [RFC] enabling -fshow-column by default

2009-06-05 Thread Jonathan Wakely
2009/6/5 Janis Johnson: > > I think the libstdc++ testsuite doesn't use the overrides for dg-error > and friends and so isn't handling the column numbers in the new way. > I'll take a look, but it might be awhile before I get to it. Thanks, Janis. I have added -fno-show-column to libstdc++-v3/scri

Re: [RFC] enabling -fshow-column by default

2009-06-05 Thread Janis Johnson
On Fri, 2009-06-05 at 10:37 -0400, Aldy Hernandez wrote: > On Fri, Jun 05, 2009 at 12:09:57AM +0100, Jonathan Wakely wrote: > > 2009/5/20 Aldy Hernandez: > > >> > > >> My only worry is that the testsuite may confuse column and line > > >> numbers and pass/fail tests because of it. > > > > > > Janis

Re: [RFC] enabling -fshow-column by default

2009-06-05 Thread Aldy Hernandez
On Fri, Jun 05, 2009 at 12:09:57AM +0100, Jonathan Wakely wrote: > 2009/5/20 Aldy Hernandez: > >> > >> My only worry is that the testsuite may confuse column and line > >> numbers and pass/fail tests because of it. > > > > Janis has a patch for the testsuite to handle all this. > > I'm seeing exac

Re: [RFC] enabling -fshow-column by default

2009-06-04 Thread Jonathan Wakely
2009/5/20 Aldy Hernandez: >> >> My only worry is that the testsuite may confuse column and line >> numbers and pass/fail tests because of it. > > Janis has a patch for the testsuite to handle all this. I'm seeing exactly this in the libstdc++ testsuite with some new tests I've written - is a fix o

Re: [RFC] enabling -fshow-column by default

2009-05-20 Thread Aldy Hernandez
On Wed, May 20, 2009 at 04:39:00PM +0200, Manuel L?pez-Ib??ez wrote: > 2009/5/20 Aldy Hernandez : > > Hi folks. > > > > Before I merge the diagnostics branch I'd like to enable it on the > > testsuite to get us all in the habit of at least being aware of columns. > > > > Joseph Myers suggested enab

Re: [RFC] enabling -fshow-column by default

2009-05-20 Thread Tom Tromey
> "Ian" == Ian Lance Taylor writes: Ian> If you haven't already done so, please check that the emacs next-error Ian> function is not affected by this. This definitely works. Tom

Re: [RFC] enabling -fshow-column by default

2009-05-20 Thread Joseph S. Myers
On Wed, 20 May 2009, Ian Lance Taylor wrote: > When we have good caret diagnostics it would also be nice to enable them > by default. However, that is a much bigger change. Does anybody have > an opinion on that? Yes, that tripling the size of output in a cascade of diagnostics is a bad idea.

Re: [RFC] enabling -fshow-column by default

2009-05-20 Thread Manuel López-Ibáñez
2009/5/20 Ian Lance Taylor : > When we have good caret diagnostics it would also be nice to enable them > by default.  However, that is a much bigger change.  Does anybody have > an opinion on that? Why don't have that discussion when (and if) caret diagnostics are available? I don't think anyone

Re: [RFC] enabling -fshow-column by default

2009-05-20 Thread Ian Lance Taylor
Aldy Hernandez writes: > Before I merge the diagnostics branch I'd like to enable it on the > testsuite to get us all in the habit of at least being aware of columns. > > Joseph Myers suggested enabling it in the compiler instead of the > testsuite. Are there any big objections to this? I agree

Re: [RFC] enabling -fshow-column by default

2009-05-20 Thread Manuel López-Ibáñez
2009/5/20 Aldy Hernandez : > Hi folks. > > Before I merge the diagnostics branch I'd like to enable it on the > testsuite to get us all in the habit of at least being aware of columns. > > Joseph Myers suggested enabling it in the compiler instead of the > testsuite.  Are there any big objections t