The overall patch is OK. Please could add testcases that test
-Wno-conversion? Thanks for doing this.
Thanks. I've committed the patch and a testcase that makes sure we
don't emit a warning if Wconversion is turned off.
-eric
On Fri, 13 Jan 2006, Eric Christopher wrote:
|
| > | OK?
| >
| > yes.
| >
| > | Did you want me to add this as a testcase?
| >
| > yes -- so that we don't regress.
|
| Ok. apparently I tested in the wrong directory and we already have a
| few testcases that test whether we're emitting warnings. I
| OK?
yes.
| Did you want me to add this as a testcase?
yes -- so that we don't regress.
Ok. apparently I tested in the wrong directory and we already have a
few testcases that test whether we're emitting warnings. I've cleaned
up the testsuite (and added a quick patch to cvt.c to add a
Eric Christopher <[EMAIL PROTECTED]> writes:
| >
| > -Wconversion is a good idea. I don't think -Wtraditional is relevant.
|
| Here's the patch to implement it. Avoids the warning in this testcase
| when -Wconversion is not passed on the command line:
|
| int func1(int i)
| {
|return i;
| }
