Re: RFC: gimple tuples data structures design

2006-06-12 Thread Diego Novillo
Daniel Berlin wrote on 06/09/06 19:32: >> /* This structure is for generic trees. */ >> struct tree_common GTY(()) >> { >> struct tree_base base; >> tree chain; >> tree type; >> union tree_ann_d *ann; >> }; > Why is there a chain in tree_common? > To avoid wholesale conversion. Initially

Re: RFC: gimple tuples data structures design

2006-06-12 Thread Diego Novillo
Steven Bosscher wrote on 06/09/06 19:12: > For gimple temporaries, are you planning on something different from > the current minimal decl (tree_decl_with_vis in tree.h; needs > re-indenting btw...)? > I was hoping to get away with just type, but I'm not sure if that's possible yet. >> /* All tr

Re: RFC: gimple tuples data structures design

2006-06-09 Thread Daniel Berlin
Andrew MacLeod wrote: > On Fri, 2006-06-09 at 19:32 -0400, Daniel Berlin wrote: >> Aldy Hernandez wrote: >>> Hi folks. >>> >> Also, one thing to throw on your todo list about gimple >> temporaries/ssa_names is that a *lot* of places create one var per >> ssa_name for no good reason. >> >> IE >> foo

Re: RFC: gimple tuples data structures design

2006-06-09 Thread Andrew MacLeod
On Fri, 2006-06-09 at 19:32 -0400, Daniel Berlin wrote: > Aldy Hernandez wrote: > > Hi folks. > > > Also, one thing to throw on your todo list about gimple > temporaries/ssa_names is that a *lot* of places create one var per > ssa_name for no good reason. > > IE > foo = create_tmp_var (type); > f

Re: RFC: gimple tuples data structures design

2006-06-09 Thread Daniel Berlin
Aldy Hernandez wrote: > Hi folks. > > Under Diego's loving whip, I've been taking a look at GIMPLE tuples, and > have come up with a possible layout for the data structures representing > the tuples. It's a mix between what Mark and Diego's originally suggested > along with a few other things ;-)

Re: RFC: gimple tuples data structures design

2006-06-09 Thread Steven Bosscher
On 6/9/06, Aldy Hernandez <[EMAIL PROTECTED]> wrote: Still missing are labels and gimple temporaries, but this should get the ball going. For labels, do you need more than just the label decls? We have labels as statements in the statement stream now, but there really isn't any reason for that

RFC: gimple tuples data structures design

2006-06-09 Thread Aldy Hernandez
Hi folks. Under Diego's loving whip, I've been taking a look at GIMPLE tuples, and have come up with a possible layout for the data structures representing the tuples. It's a mix between what Mark and Diego's originally suggested along with a few other things ;-). Still missing are labels and gi