Re: RFC: Option handling and PR 37565

2009-06-02 Thread Michael Meissner
On Fri, May 29, 2009 at 09:02:23AM -0700, Steve Ellcey wrote: > While looking into PR 37565 I began to wonder if we need to modify how > we handle optimization flag handling. Currently we have > OVERRIDE_OPTIONS, C_COMMON_OVERRIDE_OPTIONS, and OPTIMIZATION_OPTIONS to > set or override the optimiza

Re: RFC: Option handling and PR 37565

2009-05-29 Thread Ian Lance Taylor
Steve Ellcey writes: > On Fri, 2009-05-29 at 09:38 -0700, Ian Lance Taylor wrote: >> Steve Ellcey writes: >> >> > So instead of >> >if (flag_var_tracking) >> > we would have >> >if (targetm.get_optimization_flag_value(OPT_fvar_tracking)) >> >> I don't particularly want to have to make

Re: RFC: Option handling and PR 37565

2009-05-29 Thread Steve Ellcey
On Fri, 2009-05-29 at 16:56 +, Joseph S. Myers wrote: > I don't really feel that either the original proposal or this one is any > cleaner than what we have right now, and the original proposal is at least > simpler. As neither really addresses the general issues with how options > are han

Re: RFC: Option handling and PR 37565

2009-05-29 Thread Steve Ellcey
On Fri, 2009-05-29 at 09:38 -0700, Ian Lance Taylor wrote: > Steve Ellcey writes: > > > So instead of > > if (flag_var_tracking) > > we would have > > if (targetm.get_optimization_flag_value(OPT_fvar_tracking)) > > I don't particularly want to have to make an indirect function call > ev

Re: RFC: Option handling and PR 37565

2009-05-29 Thread Dave Korn
Ian Lance Taylor wrote: > Steve Ellcey writes: > >> So instead of >> if (flag_var_tracking) >> we would have >> if (targetm.get_optimization_flag_value(OPT_fvar_tracking)) > > I don't particularly want to have to make an indirect function call > every time we check a flag. I don't se

Re: RFC: Option handling and PR 37565

2009-05-29 Thread Joseph S. Myers
On Fri, 29 May 2009, Steve Ellcey wrote: > While looking into PR 37565 I began to wonder if we need to modify how > we handle optimization flag handling. Currently we have > OVERRIDE_OPTIONS, C_COMMON_OVERRIDE_OPTIONS, and OPTIMIZATION_OPTIONS to > set or override the optimization flags a user gi

Re: RFC: Option handling and PR 37565

2009-05-29 Thread Ian Lance Taylor
Steve Ellcey writes: > So instead of > if (flag_var_tracking) > we would have > if (targetm.get_optimization_flag_value(OPT_fvar_tracking)) I don't particularly want to have to make an indirect function call every time we check a flag. I don't see why we should check every time whe

RFC: Option handling and PR 37565

2009-05-29 Thread Steve Ellcey
While looking into PR 37565 I began to wonder if we need to modify how we handle optimization flag handling. Currently we have OVERRIDE_OPTIONS, C_COMMON_OVERRIDE_OPTIONS, and OPTIMIZATION_OPTIONS to set or override the optimization flags a user gives. One proposal to fix 37565 was to split OVERR