Re: RFC: Followup to PR91593

2019-10-01 Thread Jerry DeLisle
On 10/1/19 12:40 PM, Martin Sebor wrote: On 9/30/19 9:40 PM, Jerry DeLisle wrote: Copying gcc list for additional thoughts on a possible bogus warning. On 9/29/19 9:02 AM, Jerry DeLisle wrote: --- snip --- In case it helps, the warning is for the access:   # .MEM_68 = VDEF <.MEM_71>   ME

Re: RFC: Followup to PR91593

2019-10-01 Thread Martin Sebor
On 9/30/19 9:40 PM, Jerry DeLisle wrote: Copying gcc list for additional thoughts on a possible bogus warning. On 9/29/19 9:02 AM, Jerry DeLisle wrote: Hi all, --- snip --- diff --git a/libgfortran/io/write.c b/libgfortran/io/write.c index 4ef35561fdd..fc046efbe34 100644 --- a/libgfortran/i

Re: RFC: Followup to PR91593

2019-10-01 Thread Martin Sebor
On 9/30/19 9:40 PM, Jerry DeLisle wrote: Copying gcc list for additional thoughts on a possible bogus warning. On 9/29/19 9:02 AM, Jerry DeLisle wrote: Hi all, --- snip --- diff --git a/libgfortran/io/write.c b/libgfortran/io/write.c index 4ef35561fdd..fc046efbe34 100644 --- a/libgfortran/i

Re: RFC: Followup to PR91593

2019-10-01 Thread Andreas Schwab
On Sep 30 2019, Jerry DeLisle wrote: > The first attempt to fix (above) is completely off. I have tried various > combinations of code changes and I am beginning to think the warning is > bogus: > > In function ‘btoa_big’, > inlined from ‘write_b’ at ../../../trunk/libgfortran/io/write.c:121

Re: RFC: Followup to PR91593

2019-09-30 Thread Steve Kargl
On Mon, Sep 30, 2019 at 08:51:51PM -0700, Steve Kargl wrote: > > Can you just zero memory and remove the explicit setting > of the terminating '\0'? > > q = buffer; > memset(q, 0, len); > (may be dup) Upon further reading of the code, does buffer have 8*len+1 length? You would need to do

Re: RFC: Followup to PR91593

2019-09-30 Thread Steve Kargl
On Mon, Sep 30, 2019 at 08:40:29PM -0700, Jerry DeLisle wrote: > Copying gcc list for additional thoughts on a possible bogus warning. > > On 9/29/19 9:02 AM, Jerry DeLisle wrote: > > Hi all, > > > --- snip --- > > > diff --git a/libgfortran/io/write.c b/libgfortran/io/write.c > > index 4ef35561

Re: RFC: Followup to PR91593

2019-09-30 Thread Jerry DeLisle
Copying gcc list for additional thoughts on a possible bogus warning. On 9/29/19 9:02 AM, Jerry DeLisle wrote: Hi all, --- snip --- diff --git a/libgfortran/io/write.c b/libgfortran/io/write.c index 4ef35561fdd..fc046efbe34 100644 --- a/libgfortran/io/write.c +++ b/libgfortran/io/write.c @@