-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On Tue, Mar 13, 2007 at 11:15:27AM -0700, Brian Dessent wrote:
> Kai Tietz wrote:
> > Ok, I will try for this. I have to find a different editor, which is
> > not too smart as to remove trailing whitespaces ...
>
> Or just add -w to the diff options w
Andrew Haley wrote:
> I think removing trailing whitespace would be OK,
Please don't check it in, though! That would be really bad. It would
do horrible things to diffs, particularly between branches.
Not if you run the script on all active branches. Not to say it is
worth it, though.
Kai Tietz wrote:
> Ok, I will try for this. I have to find a different editor, which is not
> too smart as to remove trailing whitespaces ...
Or just add -w to the diff options when generating the patch.
Brian
On Mar 13, 2007, at 9:31 AM, Eric Weddington wrote:
At the risk of extending this out further, can someone explain to
me why
using TABs is preferrable
That is just how to the world is.
On Tue, Mar 13, 2007 at 10:31:34AM -0600, Eric Weddington wrote:
> At the risk of extending this out further, can someone explain to me why
> using TABs is preferrable, as they are interpreted, while spaces are
> unambiguous?
If anyone wants to explain this to Eric, please do so off-list.
Let's n
> -Original Message-
> From: Dave Korn [mailto:[EMAIL PROTECTED]
> Sent: Tuesday, March 13, 2007 9:59 AM
> To: 'Daniel Jacobowitz'
> Cc: 'Andrew Haley'; 'Kai Tietz'; gcc@gcc.gnu.org
> Subject: RE: Question for removing trailing whitespa
On Mar 13, 2007, at 8:01 AM, Ian Lance Taylor wrote:
Andrew Haley <[EMAIL PROTECTED]> writes:
I think removing trailing whitespace would be OK
Generally speaking, yes, but be aware, there are cases where it
should not be removed. To most, the spots that should not be changed
are obvious, o
On 13 March 2007 15:12, Daniel Jacobowitz wrote:
> On Tue, Mar 13, 2007 at 03:02:44PM -, Dave Korn wrote:
>> Can you explain that value? It's just that 1) I see vast acres and
>> acres of code where the tabstop size is two spaces 2) the coding standard
>> doesn't seem to /demand/ a specific
On Tue, Mar 13, 2007 at 03:02:44PM -, Dave Korn wrote:
> Can you explain that value? It's just that 1) I see vast acres and acres of
> code where the tabstop size is two spaces 2) the coding standard doesn't seem
> to /demand/ a specific tab size and 3) if we use 8-space TABs with the kind o
Ian Lance Taylor writes:
> I wonder if we could have some sort of svn trigger to check for
> trailing whitespace as a pre-commit check on .c and .h files?
It would be tricky, as we don't want it to barf on spaces that already
were there. The emacs magic works very well for me: I'm sure that I
Jakub Jelinek <[EMAIL PROTECTED]> wrote on 13.03.2007 16:37:34:
> On Tue, Mar 13, 2007 at 03:22:50PM +, Andrew Haley wrote:
> > Feel free to do it to your local copy. Don't do it to the gcc source
> > code repository.
>
> Well, please do it on all your checkings - all lines you have changed
Kai Tietz <[EMAIL PROTECTED]> writes:
> But I was questioned to do this stuff, for those files changed by a patch
> of mine. So I tought, if I should do, than do it for the complete gcc (not
> root) folder. How to process ?
I don't feel as strongly as Andrew about not removing trailing
whitespa
On Tue, Mar 13, 2007 at 03:22:50PM +, Andrew Haley wrote:
> Feel free to do it to your local copy. Don't do it to the gcc source
> code repository.
Well, please do it on all your checkings - all lines you have changed
to fix some bug or add a new feature shouldn't have trailing whitespace
and
Kai Tietz writes:
> Andrew Haley <[EMAIL PROTECTED]> wrote on 13.03.2007 16:03:57:
>
> > Ian Lance Taylor writes:
> > > Andrew Haley <[EMAIL PROTECTED]> writes:
> > >
> > > > Kai Tietz writes:
> > > >
> > > > > I want to remove some trailing whitespaces from gcc
> > > > > source
On 13 March 2007 15:06, Andrew Haley wrote:
> Dave Korn writes:
> > On 13 March 2007 14:02, Andrew Haley wrote:
> >
> > > Kai Tietz writes:
> > >
> > > > I want to remove some trailing whitespaces from gcc source as coding
> > > style > demands. Also I wrote, while doing a small tool for t
Andrew Haley <[EMAIL PROTECTED]> wrote on 13.03.2007 16:03:57:
> Ian Lance Taylor writes:
> > Andrew Haley <[EMAIL PROTECTED]> writes:
> >
> > > Kai Tietz writes:
> > >
> > > > I want to remove some trailing whitespaces from gcc source
> as coding style
> > > > demands. Also I wrote, w
> Kai Tietz writes:
> Also I wrote, while doing a small tool for that, a
> feature to replace horiz. tabs by spaces. But the question is by which
> width should be used ?
Tabs always are equivalent to 8 spaces.
But please DO NOT replace tabs in the GCC sources with spaces.
Ei
On 3/13/07, Andrew Haley <[EMAIL PROTECTED]> wrote:
Dave Korn writes:
> On 13 March 2007 14:02, Andrew Haley wrote:
>
> > Kai Tietz writes:
> >
> > > I want to remove some trailing whitespaces from gcc source as coding
> > style > demands. Also I wrote, while doing a small tool for that,
Dave Korn writes:
> On 13 March 2007 14:02, Andrew Haley wrote:
>
> > Kai Tietz writes:
> >
> > > I want to remove some trailing whitespaces from gcc source as coding
> > style > demands. Also I wrote, while doing a small tool for that, a
> > feature to > replace horiz. tabs by spaces.
Ian Lance Taylor writes:
> Andrew Haley <[EMAIL PROTECTED]> writes:
>
> > Kai Tietz writes:
> >
> > > I want to remove some trailing whitespaces from gcc source as coding
> > style
> > > demands. Also I wrote, while doing a small tool for that, a feature to
> > > replace horiz. tabs
On 13 March 2007 14:02, Andrew Haley wrote:
> Kai Tietz writes:
>
> > I want to remove some trailing whitespaces from gcc source as coding
> style > demands. Also I wrote, while doing a small tool for that, a
> feature to > replace horiz. tabs by spaces. But the question is by which
> width s
Andrew Haley <[EMAIL PROTECTED]> writes:
> Kai Tietz writes:
>
> > I want to remove some trailing whitespaces from gcc source as coding style
> > demands. Also I wrote, while doing a small tool for that, a feature to
> > replace horiz. tabs by spaces. But the question is by which width shoul
Kai Tietz writes:
> I want to remove some trailing whitespaces from gcc source as coding style
> demands. Also I wrote, while doing a small tool for that, a feature to
> replace horiz. tabs by spaces. But the question is by which width should
> be used ?
8.
Andrew.
Hello,
I want to remove some trailing whitespaces from gcc source as coding style
demands. Also I wrote, while doing a small tool for that, a feature to
replace horiz. tabs by spaces. But the question is by which width should
be used ? The gcc source was written by using different tab widths :(
24 matches
Mail list logo
