Re: Question about wrapv-vect-reduc-dot-s8b.c

2023-08-30 Thread Robin Dapp via Gcc
> the dump-scans. Can we do sth like > "vect_recog_dot_prod_pattern: detected\n(!FAILED)*SUCCEEDED", thus > after the dot-prod pattern dumping allow arbitrary stuff but _not_ > a "failed" and then require a "succeeded"? It took some fighting with tcl syntax until I arrived at the regex pattern be

Re: Question about wrapv-vect-reduc-dot-s8b.c

2023-08-30 Thread Robin Dapp via Gcc
>> I am wondering whether we do have some situations that >> vec_pack/vec_unpack/vec_widen_xxx/dot_prod pattern can be >> beneficial for RVV ? I have ever met some situation that vec_unpack >> can be beneficial when working on SELECT_VL but I don't which >> case > > With fixed size vectors y

Re: Question about wrapv-vect-reduc-dot-s8b.c

2023-08-30 Thread Robin Dapp via Gcc
> it's target dependent what we choose first so it's going to be > a bit difficult to adjust testcases like this (and it looks like > a testsuite issue). I think for this specific testcase changing > scan-tree-dump-times to scan-tree-dump is reasonable. Note we > really want to check that for the

Re: Re: Question about wrapv-vect-reduc-dot-s8b.c

2023-08-30 Thread Richard Biener via Gcc
e of how useful it would be. Richard. > > > juzhe.zh...@rivai.ai > > From: Robin Dapp > Date: 2023-08-30 16:06 > To: Richard Biener; juzhe.zh...@rivai.ai > CC: rdapp.gcc; gcc > Subject: Re: Question about wrapv-vect-reduc-dot-s8b.c > >> To fix it, is it necess

Re: Question about wrapv-vect-reduc-dot-s8b.c

2023-08-30 Thread Richard Biener via Gcc
On Wed, 30 Aug 2023, Robin Dapp wrote: > >> To fix it, is it necessary to support 'vec_unpack' ? > > > > both same units would be sext, not vec_unpacks_{lo,hi} - the vectorizer > > ties its hands by choosing vector types early and based on the number > > of incoming/outgoing vectors it chooses on

Re: Re: Question about wrapv-vect-reduc-dot-s8b.c

2023-08-30 Thread juzhe.zh...@rivai.ai
Dapp Date: 2023-08-30 16:06 To: Richard Biener; juzhe.zh...@rivai.ai CC: rdapp.gcc; gcc Subject: Re: Question about wrapv-vect-reduc-dot-s8b.c >> To fix it, is it necessary to support 'vec_unpack' ? > > both same units would be sext, not vec_unpacks_{lo,hi} - the vectorizer &

Re: Question about wrapv-vect-reduc-dot-s8b.c

2023-08-30 Thread Robin Dapp via Gcc
>> To fix it, is it necessary to support 'vec_unpack' ? > > both same units would be sext, not vec_unpacks_{lo,hi} - the vectorizer > ties its hands by choosing vector types early and based on the number > of incoming/outgoing vectors it chooses one or the other method. > > More precise dumping w

Re: Re: Question about wrapv-vect-reduc-dot-s8b.c

2023-08-30 Thread juzhe.zh...@rivai.ai
cted" 1 > FAIL: gcc.dg/vect/wrapv-vect-reduc-dot-s8b.c scan-tree-dump-times vect > "vect_recog_widen_mult_pattern: detected" 1 juzhe.zh...@rivai.ai From: Richard Biener Date: 2023-08-30 15:45 To: juzhe.zh...@rivai.ai CC: gcc; Robin Dapp Subject: Re: Question about wrapv-vec

Re: Question about wrapv-vect-reduc-dot-s8b.c

2023-08-30 Thread Richard Biener via Gcc
On Wed, 30 Aug 2023, juzhe.zh...@rivai.ai wrote: > Hi, I start to enable "vect" testsuite for RISC-V. > > I have a question when analyzing the 'wrapv-vect-reduc-dot-s8b.c' > It failed at: > FAIL: gcc.dg/vect/wrapv-vect-reduc-dot-s8b.c scan-tree-dump-times vect > "vect_recog_dot_prod_pattern: det

Question about wrapv-vect-reduc-dot-s8b.c

2023-08-30 Thread juzhe.zh...@rivai.ai
Hi, I start to enable "vect" testsuite for RISC-V. I have a question when analyzing the 'wrapv-vect-reduc-dot-s8b.c' It failed at: FAIL: gcc.dg/vect/wrapv-vect-reduc-dot-s8b.c scan-tree-dump-times vect "vect_recog_dot_prod_pattern: detected" 1 FAIL: gcc.dg/vect/wrapv-vect-reduc-dot-s8b.c scan-tre