Re: Manually set sret parameter

2025-06-30 Thread Andrew Pinski via Gcc
On Mon, Jun 30, 2025 at 12:25 PM Andrew Pinski wrote: > > On Mon, Jun 30, 2025 at 12:01 PM Fractal Fir wrote: > > > > Thank you so much for the help! It seems like the TREE_ADDRESSABLE bit is > > indeed what we have been looking for. > > > > In regards to your questions: > > > > Sadly, most of t

Re: Manually set sret parameter

2025-06-30 Thread Andrew Pinski via Gcc
On Mon, Jun 30, 2025 at 12:01 PM Fractal Fir wrote: > > Thank you so much for the help! It seems like the TREE_ADDRESSABLE bit is > indeed what we have been looking for. > > In regards to your questions: > > Sadly, most of this is barely documented if at all. The rust compiler > documentation is

Re: Manually set sret parameter

2025-06-30 Thread Fractal Fir via Gcc
Thank you so much for the help! It seems like the TREE_ADDRESSABLE bit is indeed what we have been looking for. In regards to your questions: Sadly, most of this is barely documented if at all. The rust compiler documentation is... not good. I only know about this because somebody mentioned this

Re: Manually set sret parameter

2025-06-30 Thread Andrew Pinski via Gcc
On Mon, Jun 30, 2025 at 11:22 AM Andrew Pinski wrote: > > On Mon, Jun 30, 2025 at 11:10 AM Fractal Fir wrote: > > > > Hi! > > > > I am one of the folk currently working on `rustc_codegen_gcc`, and I > > thought that I will provide some more context. > > > > > So I looked into this further, it is

Re: Manually set sret parameter

2025-06-30 Thread Andrew Pinski via Gcc
On Mon, Jun 30, 2025 at 11:10 AM Fractal Fir wrote: > > Hi! > > I am one of the folk currently working on `rustc_codegen_gcc`, and I thought > that I will provide some more context. > > > So I looked into this further, it is not rust that specifies sret but > rather rust transformation into llvm

Re: Manually set sret parameter

2025-06-30 Thread Fractal Fir via Gcc
Hi! I am one of the folk currently working on `rustc_codegen_gcc`, and I thought that I will provide some more context. > So I looked into this further, it is not rust that specifies sret but rather rust transformation into llvm code generation that does that. > So you need to explain what exact

Re: Manually set sret parameter

2025-06-30 Thread Antoni Boucher via Gcc
Hi. Let me introduce you Fractal Fir who's a student working on rustc_codegen_gcc for the Google Summer of Code. He found some ABI issues (one related to sret) in rustc_codegen_gcc and wanted to join this discussion in order to share more details about what we want to achieve here. Thanks. Le

Re: Manually set sret parameter

2025-06-30 Thread Antoni Boucher via Gcc
Le 2025-06-29 à 19 h 42, Andrew Pinski a écrit : On Sun, Jun 29, 2025, 4:36 PM Antoni Boucher > wrote: Le 2025-06-29 à 10 h 46, Andrew Pinski a écrit : > > > On Sun, Jun 29, 2025, 7:43 AM Andrew Pinski mailto:pins...@gmail.com> >

Re: Manually set sret parameter

2025-06-30 Thread Andrew Pinski via Gcc
On Mon, Jun 30, 2025 at 7:25 AM Antoni Boucher wrote: > > > > Le 2025-06-29 à 19 h 42, Andrew Pinski a écrit : > > > > > > On Sun, Jun 29, 2025, 4:36 PM Antoni Boucher > > wrote: > > > > > > > > Le 2025-06-29 à 10 h 46, Andrew Pinski a écrit : > > > > > > >

Re: Manually set sret parameter

2025-06-29 Thread Andrew Pinski via Gcc
On Sun, Jun 29, 2025, 4:42 PM Andrew Pinski wrote: > > > On Sun, Jun 29, 2025, 4:36 PM Antoni Boucher wrote: > >> >> >> Le 2025-06-29 à 10 h 46, Andrew Pinski a écrit : >> > >> > >> > On Sun, Jun 29, 2025, 7:43 AM Andrew Pinski > > > wrote: >> > >> > On Sun, Jun 29,

Re: Manually set sret parameter

2025-06-29 Thread Andrew Pinski via Gcc
On Sun, Jun 29, 2025, 4:36 PM Antoni Boucher wrote: > > > Le 2025-06-29 à 10 h 46, Andrew Pinski a écrit : > > > > > > On Sun, Jun 29, 2025, 7:43 AM Andrew Pinski > > wrote: > > > > On Sun, Jun 29, 2025, 7:36 AM Antoni Boucher via Gcc > > mailto:gcc@gcc.gnu.org>

Re: Manually set sret parameter

2025-06-29 Thread Antoni Boucher via Gcc
Le 2025-06-29 à 10 h 46, Andrew Pinski a écrit : On Sun, Jun 29, 2025, 7:43 AM Andrew Pinski > wrote: On Sun, Jun 29, 2025, 7:36 AM Antoni Boucher via Gcc mailto:gcc@gcc.gnu.org>> wrote: Hi. Is there a way in GENERIC to specify that a para

Re: Manually set sret parameter

2025-06-29 Thread Andrew Pinski via Gcc
On Sun, Jun 29, 2025, 7:43 AM Andrew Pinski wrote: > On Sun, Jun 29, 2025, 7:36 AM Antoni Boucher via Gcc > wrote: > >> Hi. >> Is there a way in GENERIC to specify that a parameter will be passed in >> "sret", or is this solely controlled by the hook struct_value_rtx? >> > > It is only controlle

Re: Manually set sret parameter

2025-06-29 Thread Andrew Pinski via Gcc
On Sun, Jun 29, 2025, 7:36 AM Antoni Boucher via Gcc wrote: > Hi. > Is there a way in GENERIC to specify that a parameter will be passed in > "sret", or is this solely controlled by the hook struct_value_rtx? > It is only controlled by the hook. What exactly are trying to do? You could set the r

Manually set sret parameter

2025-06-29 Thread Antoni Boucher via Gcc
Hi. Is there a way in GENERIC to specify that a parameter will be passed in "sret", or is this solely controlled by the hook struct_value_rtx? Thanks.