Re: How to improve the location of a gcc diagnostic

2016-06-23 Thread Senthil Kumar Selvaraj
David Malcolm writes: > A user filed a bug about a bad location in a warning. It was marked as > an "easyhack" in bugzilla, and I had a go at fixing it. > > I though it may be useful for new GCC developers if I document what I > did to fix it. > > FWIW, the bug was PR c/71610 > i.e. https://gc

Re: How to improve the location of a gcc diagnostic

2016-06-23 Thread Jason Merrill
On Thu, Jun 23, 2016 at 5:04 PM, David Malcolm wrote: > Step 10: commit to svn > > Once the patch is approved, commit it to svn. (FWIW I do all of my > development work in git; I have an svn checkout that I use purely for > the final checkin, having smoketested the patch first). Why not checkin

Re: How to improve the location of a gcc diagnostic

2016-06-23 Thread Mikhail Maltsev
On 06/23/2016 17:04, David Malcolm wrote: > A user filed a bug about a bad location in a warning. It was marked as > an "easyhack" in bugzilla, and I had a go at fixing it. > > I though it may be useful for new GCC developers if I document what I > did to fix it. Shouldn't this also go to the wik

How to improve the location of a gcc diagnostic

2016-06-23 Thread David Malcolm
A user filed a bug about a bad location in a warning. It was marked as an "easyhack" in bugzilla, and I had a go at fixing it. I though it may be useful for new GCC developers if I document what I did to fix it. FWIW, the bug was PR c/71610 i.e. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=716