Re: Edges, predictions, and GC crashes ...

2005-06-04 Thread Jan Hubicka
> Jan Hubicka wrote: > > > I've comitted the attached patch. I didn't suceed to reproduce your > > failures, but Danny reported it fixes his and it bootstrap/regtests > > i686-pc-gnu-linux. > > Thanks; this does fix one crash on s390x, but doesn't fix the > pass57-frag crashes on s390. > > What

Re: Edges, predictions, and GC crashes ...

2005-06-04 Thread Ulrich Weigand
Jan Hubicka wrote: > I've comitted the attached patch. I didn't suceed to reproduce your > failures, but Danny reported it fixes his and it bootstrap/regtests > i686-pc-gnu-linux. Thanks; this does fix one crash on s390x, but doesn't fix the pass57-frag crashes on s390. What happens is that aft

Re: Edges, predictions, and GC crashes ...

2005-06-03 Thread Jan Hubicka
> Jan Hubicka wrote: > > > I didn't have any cleanup_cfg in between earliest place putting > > predictions and the profiling pass consuming them, so this scenario > > didn't happen. This has however changed a long time ago. I guess just > > teaching remove_edge to walk prediction list if it is p

Re: Edges, predictions, and GC crashes ...

2005-06-02 Thread Ulrich Weigand
Jan Hubicka wrote: > I didn't have any cleanup_cfg in between earliest place putting > predictions and the profiling pass consuming them, so this scenario > didn't happen. This has however changed a long time ago. I guess just > teaching remove_edge to walk prediction list if it is present and k

Re: Edges, predictions, and GC crashes ...

2005-06-02 Thread Jan Hubicka
> Hello, > > I'm seeing compiler crashes during garbage collection when using mudflap. > > The problem appears to be that some basic_block_def structures point to > edge_prediction structures which point to edge_def structures that have > already been ggc_free()'d. > > Now, looking at remove_edg

Re: Edges, predictions, and GC crashes ...

2005-06-02 Thread Daniel Berlin
On Thu, 2 Jun 2005, Ulrich Weigand wrote: Hello, I'm seeing compiler crashes during garbage collection when using mudflap. The problem appears to be that some basic_block_def structures point to edge_prediction structures which point to edge_def structures that have already been ggc_free()

Edges, predictions, and GC crashes ...

2005-06-02 Thread Ulrich Weigand
Hello, I'm seeing compiler crashes during garbage collection when using mudflap. The problem appears to be that some basic_block_def structures point to edge_prediction structures which point to edge_def structures that have already been ggc_free()'d. Now, looking at remove_edge (cfg.c) is does