Re: Diagnostic Messaging Suggestion

2009-04-17 Thread Daniel Jacobowitz
On Fri, Apr 17, 2009 at 11:58:48AM -0600, Tom Tromey wrote: > Chris> Clang just prints the include stack information when anything > Chris> in the include stack differs between two consecutive > Chris> diagnostics. > > We could easily do that too. FWIW, I think this would be quite useful. -- Da

Re: Diagnostic Messaging Suggestion

2009-04-17 Thread Tom Tromey
> "Joe" == Joe Buck writes: Joe> If, for definitions, the compiler keeps track of this detail, it Joe> would be possible to reliably print Joe> foo.h:11 error: redefinition of `a' (file was included more than once) Joe> if the printable line number is the same but the internal line number Joe

Re: Diagnostic Messaging Suggestion

2009-04-17 Thread Chris Lattner
On Apr 16, 2009, at 8:44 PM, Joe Buck wrote: On Thu, Apr 16, 2009 at 03:40:47PM -0700, Arthur Schwarz wrote: The rock has dropped. The answer is quoted below: "My best guess is that a header file is included twice, and lacks guards, hence the message is correct: the function is being define

Re: Diagnostic Messaging Suggestion

2009-04-16 Thread Joe Buck
On Thu, Apr 16, 2009 at 03:40:47PM -0700, Arthur Schwarz wrote: > The rock has dropped. The answer is quoted below: > > "My best guess is that a header file is included twice, and lacks guards, > hence the message is correct: the function is being defined twice, from the > same source location."

Re: Diagnostic Messaging Suggestion

2009-04-16 Thread Arthur Schwarz
Thanks to everyone. The rock has dropped. The answer is quoted below: "My best guess is that a header file is included twice, and lacks guards, hence the message is correct: the function is being defined twice, from the same source location." I had put my friends following my 'include guard'

Re: Diagnostic Messaging Suggestion

2009-04-16 Thread Arthur Schwarz
I forgot to say 'thanks James', thanks. Well, spurred on by the whimsy that I need a solution to the problem (however dolorous), I experimented. I've commented most everything at least once and the net effect is that only the 'operator<<' gets a nasty message. I've checked the include files th

Re: Diagnostic Messaging Suggestion

2009-04-16 Thread Arthur Schwarz
> > Can you show code that reproduces the issue?  My best > guess is that a > header file is included twice, and lacks guards, hence the > message is > correct: the function is being defined twice, from the same > source > location. > > -- James > Code (unadulterated and full of original

Re: Diagnostic Messaging Suggestion

2009-04-16 Thread James Dennett
On Thu, Apr 16, 2009 at 12:06 PM, Arthur Schwarz wrote: > > > > Suggested Messaging: Messaging seems redundant in indicating that function > has been redifined twice. One of the messages should be removed. More to the > point, I think the messaging may be erroneous - code fragment follows. > > >

Diagnostic Messaging Suggestion

2009-04-16 Thread Arthur Schwarz
Suggested Messaging: Messaging seems redundant in indicating that function has been redifined twice. One of the messages should be removed. More to the point, I think the messaging may be erroneous - code fragment follows. g++-4 Diagnostic Messaging In file included from partition.cpp:66: i

Re: Diagnostic Messaging Suggestion

2009-04-09 Thread Dave Korn
Arthur Schwarz wrote: > > (I've already provided an indication of a willingness to do something to > Robert Dewar). Does his wife know? :-O cheers, DaveK (I'll get my coat)

Re: Diagnostic Messaging Suggestion

2009-04-09 Thread Ian Lance Taylor
Arthur Schwarz writes: > I didn't mean to volunteer. I'm retired and therefor am both > unhireable and hove no free time. But if you really (really) want > ... I'd be glad to contribute in any way that I can. Provide what you > need that I can do, and a means to give you feedback and I'm yours.

Re: Diagnostic Messaging Suggestion

2009-04-09 Thread Arthur Schwarz
I didn't mean to volunteer. I'm retired and therefor am both unhireable and hove no free time. But if you really (really) want ... I'd be glad to contribute in any way that I can. Provide what you need that I can do, and a means to give you feedback and I'm yours. (I've already provided an ind

Re: Diagnostic Messaging Suggestion

2009-04-09 Thread Joe Buck
On Thu, Apr 09, 2009 at 11:03:20AM -0700, Ian Lance Taylor wrote: > Arthur Schwarz writes: > > 2: Stream errors are tortuous to decode to find the cause of > >error..Any thought to simplification? > > > >In particular: 'stream << something_wrong;' can produce a > >multiline message wit

Re: Diagnostic Messaging Suggestion

2009-04-09 Thread Ian Lance Taylor
Arthur Schwarz writes: > 1: Any thought to including column numbers with line numbers on >    ERROR messages? Looking at a diagnostic message for a complex >    statement  without a column number has lead to making an >    incorrect assumption as to what in the line is faulty. A >    column nu

Diagnostic Messaging Suggestion

2009-04-09 Thread Arthur Schwarz
Please take the comments as constructive and not adversarial. I use GCC and have hopes of sending it a Valentine's Day gift. 1: Any thought to including column numbers with line numbers on    ERROR messages? Looking at a diagnostic message for a complex    statement  without a column number has