Re: [trans-mem] RFC Fix missing REG_TM notes

2012-01-31 Thread Torvald Riegel
On Tue, 2012-01-10 at 17:29 -0500, Patrick Marlier wrote: > On 01/09/2012 04:19 PM, Patrick Marlier wrote: > > On 01/09/2012 04:04 PM, Torvald Riegel wrote: > >> On Mon, 2012-01-09 at 15:55 -0500, Patrick Marlier wrote: > >>> On my side, I was able to fix the problem with genome but the patch is >

Re: [trans-mem] RFC Fix missing REG_TM notes

2012-01-10 Thread Patrick Marlier
On 01/10/2012 05:39 PM, Richard Henderson wrote: Also outstanding is that the return value setup for beginTransaction needs to be adjusted into the new block. I.e. we current generate (set (reg eax) (call _ITM_beginTransaction)) (set (reg psuedo) (reg eax)) .Lrestart: // rest of tm

Re: [trans-mem] RFC Fix missing REG_TM notes

2012-01-10 Thread Richard Henderson
On 01/11/2012 09:29 AM, Patrick Marlier wrote: > + /* ??? mark only the first call, is it right? */ > + for (insn = get_last_insn (); > +insn && !CALL_P (insn); > insn = next_real_insn (insn)) > continue; FYI, there shall only be one call, surely. Hmm. I suppose

Re: [trans-mem] RFC Fix missing REG_TM notes

2012-01-10 Thread Patrick Marlier
On 01/09/2012 04:19 PM, Patrick Marlier wrote: On 01/09/2012 04:04 PM, Torvald Riegel wrote: On Mon, 2012-01-09 at 15:55 -0500, Patrick Marlier wrote: On my side, I was able to fix the problem with genome but the patch is not clean at all and I need to find exactly where and why the problem was

Re: [trans-mem] RFC Fix missing REG_TM notes

2012-01-09 Thread Patrick Marlier
On 01/09/2012 04:19 PM, Patrick Marlier wrote: On 01/09/2012 04:04 PM, Torvald Riegel wrote: On Mon, 2012-01-09 at 15:55 -0500, Patrick Marlier wrote: On my side, I was able to fix the problem with genome but the patch is not clean at all and I need to find exactly where and why the problem was

Re: [trans-mem] RFC Fix missing REG_TM notes

2012-01-09 Thread Patrick Marlier
On 01/09/2012 04:04 PM, Torvald Riegel wrote: On Mon, 2012-01-09 at 15:55 -0500, Patrick Marlier wrote: On my side, I was able to fix the problem with genome but the patch is not clean at all and I need to find exactly where and why the problem was fixed. What do you mean? Do you still see is

Re: [trans-mem] RFC Fix missing REG_TM notes

2012-01-09 Thread Torvald Riegel
On Mon, 2012-01-09 at 15:55 -0500, Patrick Marlier wrote: > On my side, I was able to fix the problem with genome but the patch is > not clean at all and I need to find exactly where and why the problem > was fixed. What do you mean? Do you still see issues with Genome, even with the returns-tw

[trans-mem] RFC Fix missing REG_TM notes

2012-01-09 Thread Patrick Marlier
In trans-mem.c:make_tm_edge, it gets the slot for insertion but it doesn't set it. Fixing this makes cfgexpand.c: mark_transaction_restart_calls fails because sometimes the instruction is not found. In the attached patch, I just ignore if insn is NULL but do you have an idea why this happens?