Re: [RFD] Simplifying subregs in LRA

2017-02-03 Thread Vladimir Makarov
On 02/01/2017 06:52 PM, Matthew Fortune wrote: Hi all, I've copied you as you have each made some significant change to a function in LRA which I guess makes you de-facto experts. I've spent a while researching the history of simplify_operand_subreg and in particular the behaviour for subregs

Re: [RFD] Simplifying subregs in LRA

2017-02-03 Thread Eric Botcazou
> If a MEM subreg is neither simplified to an outermode MEM nor reloaded > in innermode then I believe LRA will never resolve the subreg. Even if that > is not true I'm fairly certain the addition of the code has changed > behaviour and that the change is not well understood, as explained above.

RE: [RFD] Simplifying subregs in LRA

2017-02-03 Thread Matthew Fortune
Eric Botcazou writes: > > (r243782 git:856bd6f) > > This is another case of multiple changes where some were not critical > > and overall there is a dangerous one here I believe. The primary aim > > of this change is to reload the address before reloading the inner > > subreg. This appears to be

Re: [RFD] Simplifying subregs in LRA

2017-02-03 Thread Eric Botcazou
> (r243782 git:856bd6f) > This is another case of multiple changes where some were not critical and > overall there is a dangerous one here I believe. The primary aim of this > change is to reload the address before reloading the inner subreg. This > appears to be a dormant bug since day1 as the

[RFD] Simplifying subregs in LRA

2017-02-01 Thread Matthew Fortune
Hi all, I've copied you as you have each made some significant change to a function in LRA which I guess makes you de-facto experts. I've spent a while researching the history of simplify_operand_subreg and in particular the behaviour for subregs of memory. For my sake if no-one else here is a