Re: [RFC] missing return warnings

2007-09-06 Thread Mark Mitchell
Jan Hubicka wrote: > One problem that I am concerned about is that C++ frontend is actually > trying to avoid instantiating some stuff that it knows will not be > needed if not inlined. I would kill this logic, but I hope this is the > case where the feature is not worth the maintenance cost. We

Re: [RFC] missing return warnings

2007-09-06 Thread Jan Hubicka
> Jan Hubicka wrote: > > > I am basically trying to avoid need for DECL_INLINE (while keeping > > DECL_DECLARED_INLINE and DECL_UNINLINABLE for frontend use) - inliner is > > now doing all the job himself to figure out what is or isn't needed. > > That certainly makes sense to me. > > > With the

Re: [RFC] missing return warnings

2007-09-06 Thread Mark Mitchell
Jan Hubicka wrote: > I am basically trying to avoid need for DECL_INLINE (while keeping > DECL_DECLARED_INLINE and DECL_UNINLINABLE for frontend use) - inliner is > now doing all the job himself to figure out what is or isn't needed. That certainly makes sense to me. > With the noreturn warning

Re: [RFC] missing return warnings

2007-09-06 Thread Jan Hubicka
> Jan Hubicka wrote: > > > For C++ there are number of cases I need to go through dealing with > > attempts to not instantiate non-inline methods that won't be needed. > > I'm not sure exactly what cases you're referring to, but please be > careful. For example, changing if/when we instantiate t

Re: [RFC] missing return warnings

2007-09-06 Thread Mark Mitchell
Jan Hubicka wrote: > For C++ there are number of cases I need to go through dealing with > attempts to not instantiate non-inline methods that won't be needed. I'm not sure exactly what cases you're referring to, but please be careful. For example, changing if/when we instantiate template functi

Re: [RFC] missing return warnings

2007-09-06 Thread Manuel López-Ibáñez
On 06/09/07, Jan Hubicka <[EMAIL PROTECTED]> wrote: > I wonder what we want to do here - I guess we can either make the > warning unconditional and declare it as two indpendent things or we can > just drop the feature since user will get properly warned on every > function he actually uses. > > Wha

[RFC] missing return warnings

2007-09-06 Thread Jan Hubicka
Hi, I am looking into what parts of frontend stil depends on frontend inline decision (ie DECL_INLINE now ignored by middle end). All these uses strike wrong, given that inlining decisions are independent on it. These divergences for example requires us to enable expensive -finline-functions for -