Re: [RFC] Thoughts on reordering the source tree

2009-05-07 Thread Kaz Kojima
Steven Bosscher wrote: > Kaz, can you commit a patch for sh.c? I've just applied the patch below. Regards, kaz -- 2009-05-08 Kaz Kojima * config/sh/sh.c: Do not include c-pragma.h. --- ORIG/trunk/gcc/config/sh/sh.c 2009-05-06 07:11:59.0 +0900 +++ trunk/gcc/conf

Re: [RFC] Thoughts on reordering the source tree

2009-05-07 Thread Andrew Pinski
On Thu, May 7, 2009 at 6:00 PM, Andrew Pinski wrote: > Thanks, > Andrew Pinski > > ChangeLog: > > * config/spu/spu.c: Remove include of c-common.c Yes I did have a typo in the changelog I sent to the list, I changed it before committing (s/c-common.c/c-common.h/). Thanks, Andrew Pinski

Re: [RFC] Thoughts on reordering the source tree

2009-05-07 Thread Andrew Pinski
On Fri, May 1, 2009 at 1:46 PM, Steven Bosscher wrote: >> config/spu/spu.c:#include "c-common.h" > > These I will need to check via a cross compiler. Andrew P., maybe you > can look at SPU? It was not needed since: 2006-11-30 Andrew Pinski * config/spu/spu.c (spu_builtin_range): Move

Re: [RFC] Thoughts on reordering the source tree

2009-05-07 Thread Steven Bosscher
On Sun, May 3, 2009 at 6:34 AM, Kaz Kojima wrote: > Steven Bosscher wrote: > [snip] >> config/sh/sh.c:#include "c-pragma.h" > > FYI, I've confirmed that there are no problems without > this line for sh4-unknown-linux-gnu. > > Regards, >        kaz > And I have successfully bootstrapped with this

Re: [RFC] Thoughts on reordering the source tree

2009-05-02 Thread Kaz Kojima
Steven Bosscher wrote: [snip] > config/sh/sh.c:#include "c-pragma.h" FYI, I've confirmed that there are no problems without this line for sh4-unknown-linux-gnu. Regards, kaz

Re: [RFC] Thoughts on reordering the source tree

2009-05-02 Thread Joseph S. Myers
On Fri, 1 May 2009, Steven Bosscher wrote: > > config/h8300/h8300.c:#include "c-pragma.h" > > config/i386/i386.c:#include "c-common.h" > > config/sh/sh.c:#include "c-pragma.h" > > config/spu/spu.c:#include "c-common.h" > > These I will need to check via a cross compiler. Andrew P., maybe you > ca

Re: [RFC] Thoughts on reordering the source tree

2009-05-01 Thread Joseph S. Myers
On Fri, 1 May 2009, Steven Bosscher wrote: > > And these are the problem inclusions of files specific to C and ObjC from > > files also shared with C++: > > > > c-common.c:#include "c-tree.h" > > c-dump.c:#include "c-tree.h" > > c-gimplify.c:#include "c-tree.h" > > c-lex.c:#include "c-tree.h" > >

Re: [RFC] Thoughts on reordering the source tree

2009-05-01 Thread Steven Bosscher
On Fri, May 1, 2009 at 3:54 PM, Joseph S. Myers wrote: > attribs.c:#include "c-common.h" > cgraphunit.c:#include "c-common.h" > ipa-pure-const.c:#include "c-common.h" > ipa-reference.c:#include "c-common.h" > ipa-struct-reorg.c:#include "c-tree.h" > ipa-struct-reorg.c:#include "c-common.h" > ipa-t

Re: [RFC] Thoughts on reordering the source tree

2009-05-01 Thread Jan Hubicka
> On Fri, May 1, 2009 at 2:05 PM, Steven Bosscher wrote: > > Hello, > > > > The GCC source tree is getting really big.  We currently have in gcc/: > > > > - 337 .c files > > - 171 .h files > > > > Personally, I think the source tree is quite a mess, the way it is > > now.  A long time ago (I can't

Re: [RFC] Thoughts on reordering the source tree

2009-05-01 Thread Andrew Haley
Richard Guenther wrote: > Branches will get confused. SVN does not really track file moves. So > I think this is not a stage1 but more a stage3 thing. > > It also will make grepping even more painful than it is now (remember > that ada change to introduce a 3rd directory level here ...). > > I

Re: [RFC] Thoughts on reordering the source tree

2009-05-01 Thread Richard Guenther
On Fri, May 1, 2009 at 2:05 PM, Steven Bosscher wrote: > Hello, > > The GCC source tree is getting really big.  We currently have in gcc/: > > - 337 .c files > - 171 .h files > > Personally, I think the source tree is quite a mess, the way it is > now.  A long time ago (I can't find the threads in

Re: [RFC] Thoughts on reordering the source tree

2009-05-01 Thread Steven Bosscher
On Fri, May 1, 2009 at 7:01 PM, Joseph S. Myers wrote: > On Fri, 1 May 2009, Steven Bosscher wrote: > >> On Fri, May 1, 2009 at 6:48 PM, Joseph S. Myers >> wrote: >> > On Fri, 1 May 2009, Steven Bosscher wrote: >> > >> >> Actually nothing uses it, except one case of %qE.  And some passes >> >> f

Re: [RFC] Thoughts on reordering the source tree

2009-05-01 Thread Joseph S. Myers
On Fri, 1 May 2009, Steven Bosscher wrote: > On Fri, May 1, 2009 at 6:48 PM, Joseph S. Myers > wrote: > > On Fri, 1 May 2009, Steven Bosscher wrote: > > > >> Actually nothing uses it, except one case of %qE.  And some passes > >> forgot to include splay-tree.h but got it via c-*.h. > > > > There

Re: [RFC] Thoughts on reordering the source tree

2009-05-01 Thread Steven Bosscher
On Fri, May 1, 2009 at 6:48 PM, Joseph S. Myers wrote: > On Fri, 1 May 2009, Steven Bosscher wrote: > >> Actually nothing uses it, except one case of %qE.  And some passes >> forgot to include splay-tree.h but got it via c-*.h. > > There should be no problem with %qE in non-front-end files, since:

Re: [RFC] Thoughts on reordering the source tree

2009-05-01 Thread Joseph S. Myers
On Fri, 1 May 2009, Steven Bosscher wrote: > Actually nothing uses it, except one case of %qE. And some passes > forgot to include splay-tree.h but got it via c-*.h. There should be no problem with %qE in non-front-end files, since: 2009-04-23 Rafael Avila de Espindola * c-format.c

Re: [RFC] Thoughts on reordering the source tree

2009-05-01 Thread Steven Bosscher
On Fri, May 1, 2009 at 4:13 PM, Joseph S. Myers wrote: > On Fri, 1 May 2009, Steven Bosscher wrote: > >> Eh, ouch. >> >> I'll see if I can clean this up.  I don't believe for 90% of these >> files that they should include c-common.h / c-tree.h.  Looks like >> history and the usual carelessness whe

Re: [RFC] Thoughts on reordering the source tree

2009-05-01 Thread Joseph S. Myers
On Fri, 1 May 2009, Steven Bosscher wrote: > Eh, ouch. > > I'll see if I can clean this up. I don't believe for 90% of these > files that they should include c-common.h / c-tree.h. Looks like > history and the usual carelessness when adding #include lines to new > files/passes. Thanks! I agre

Re: [RFC] Thoughts on reordering the source tree

2009-05-01 Thread Steven Bosscher
On Fri, May 1, 2009 at 3:54 PM, Joseph S. Myers wrote: > On Fri, 1 May 2009, Joseph S. Myers wrote: > >> On Fri, 1 May 2009, Steven Bosscher wrote: >> >> > - c-* go to gcc/c (including c-common.*, 29 files) >> >> I still suggest using a separate c-family/ directory for those files also >> shared w

Re: [RFC] Thoughts on reordering the source tree

2009-05-01 Thread Joseph S. Myers
On Fri, 1 May 2009, Joseph S. Myers wrote: > On Fri, 1 May 2009, Steven Bosscher wrote: > > > - c-* go to gcc/c (including c-common.*, 29 files) > > I still suggest using a separate c-family/ directory for those files also > shared with C++. There are some cleanups that need doing of files tha

Re: [RFC] Thoughts on reordering the source tree

2009-05-01 Thread Joseph S. Myers
On Fri, 1 May 2009, Steven Bosscher wrote: > - c-* go to gcc/c (including c-common.*, 29 files) I still suggest using a separate c-family/ directory for those files also shared with C++. There are some cleanups that need doing of files that include C headers that shouldn't, and of c-family fil

Re: [RFC] Thoughts on reordering the source tree

2009-05-01 Thread Manuel López-Ibáñez
2009/5/1 Steven Bosscher : > Hello, > > Now that GCC uses subversion, we can move files around without > destroying the file revision history, right? And we are in stage1, the > perfect time for Big Changes like re-ordering the source tree. If you going to tackle this, I would suggest to start wit

Re: [RFC] Thoughts on reordering the source tree

2009-05-01 Thread Richard Kenner
I'm in favor of such a reorganization, but would suggest: (1) tree-* to go to gcc/tree-opt (2) Not distinguish between the various rtl passes (why is sched "code generation", for example?) and put all in gcc/rtl (3) Not do this: > - basic intermediate language support stays in gcc/ or goes to gc

[RFC] Thoughts on reordering the source tree

2009-05-01 Thread Steven Bosscher
Hello, The GCC source tree is getting really big. We currently have in gcc/: - 337 .c files - 171 .h files Personally, I think the source tree is quite a mess, the way it is now. A long time ago (I can't find the threads involved) there was some discussion about re-ordering the source tree a b