Re: [Patch] contrib/mklog.py: Improve PR handling (was: git gcc-commit-mklog doesn't extract PR number to ChangeLog)

2021-06-21 Thread Iain Sandoe via Gcc
> On 21 Jun 2021, at 08:26, Martin Liška wrote: > > On 6/21/21 8:42 AM, Tobias Burnus wrote: >> On 18.06.21 16:41, Jason Merrill wrote: >>> >>> * Being able to specify the PR numbers on the command line in addition >>>(currently, they are only extracted from the testsuite patches)

Re: [Patch] contrib/mklog.py: Improve PR handling (was: git gcc-commit-mklog doesn't extract PR number to ChangeLog)

2021-06-21 Thread Martin Liška
On 6/18/21 1:40 PM, Jonathan Wakely wrote: On Fri, 18 Jun 2021 at 12:26, Tobias Burnus wrote: On 18.06.21 13:10, Jonathan Wakely wrote: On Fri, 18 Jun 2021 at 12:05, Tobias Burnus wrote: PR c++/12394 - internal compiler error: in write_type, at cp/mangle.c:1517 PR fortran/100123 - -ftree-fr

Re: [Patch] contrib/mklog.py: Improve PR handling (was: git gcc-commit-mklog doesn't extract PR number to ChangeLog)

2021-06-21 Thread Martin Liška
On 6/21/21 8:42 AM, Tobias Burnus wrote: On 18.06.21 16:41, Jason Merrill wrote:     * Being able to specify the PR numbers on the command line in addition    (currently, they are only extracted from the testsuite patches) This bit seems unnecessary to me, since we want the commit to inc

Re: [Patch] contrib/mklog.py: Improve PR handling (was: git gcc-commit-mklog doesn't extract PR number to ChangeLog)

2021-06-20 Thread Tobias Burnus
On 18.06.21 16:41, Jason Merrill wrote: * Being able to specify the PR numbers on the command line in addition (currently, they are only extracted from the testsuite patches) This bit seems unnecessary to me, since we want the commit to include tests that identify the PR. I full h

Re: [Patch] contrib/mklog.py: Improve PR handling

2021-06-18 Thread Iain Sandoe via Gcc
> On 18 Jun 2021, at 17:47, Martin Sebor via Gcc wrote: > > On 6/18/21 8:41 AM, Jason Merrill via Gcc wrote: >> On Fri, Jun 18, 2021 at 7:06 AM Tobias Burnus >> wrote: >>> On 18.06.21 11:32, Richard Earnshaw via Gcc wrote: On 17/06/2021 18:21, Jakub Jelinek wrote: > mklog as is doesn

Re: [Patch] contrib/mklog.py: Improve PR handling

2021-06-18 Thread Martin Sebor via Gcc
On 6/18/21 8:41 AM, Jason Merrill via Gcc wrote: On Fri, Jun 18, 2021 at 7:06 AM Tobias Burnus wrote: On 18.06.21 11:32, Richard Earnshaw via Gcc wrote: On 17/06/2021 18:21, Jakub Jelinek wrote: mklog as is doesn't fill in the details (descriptions of the changes to each function etc.), nor

Re: [Patch] contrib/mklog.py: Improve PR handling

2021-06-18 Thread Martin Sebor via Gcc
On 6/18/21 5:25 AM, Tobias Burnus wrote: On 18.06.21 13:10, Jonathan Wakely wrote: On Fri, 18 Jun 2021 at 12:05, Tobias Burnus wrote: PR c++/12394 - internal compiler error: in write_type, at cp/mangle.c:1517 PR fortran/100123 - -ftree-fre gives incorrect result in subroutine with array decla

Re: [Patch] contrib/mklog.py: Improve PR handling (was: git gcc-commit-mklog doesn't extract PR number to ChangeLog)

2021-06-18 Thread Jason Merrill via Gcc
On Fri, Jun 18, 2021 at 7:06 AM Tobias Burnus wrote: > On 18.06.21 11:32, Richard Earnshaw via Gcc wrote: > > On 17/06/2021 18:21, Jakub Jelinek wrote: > >> mklog as is doesn't fill in the details (descriptions of the changes > >> to each function etc.), nor is realiable in many cases, and with J

Re: [Patch] contrib/mklog.py: Improve PR handling (was: git gcc-commit-mklog doesn't extract PR number to ChangeLog)

2021-06-18 Thread Jonathan Wakely via Gcc
On Fri, 18 Jun 2021 at 12:26, Tobias Burnus wrote: > > On 18.06.21 13:10, Jonathan Wakely wrote: > > > On Fri, 18 Jun 2021 at 12:05, Tobias Burnus wrote: > >> PR c++/12394 - internal compiler error: in write_type, at cp/mangle.c:1517 > >> PR fortran/100123 - -ftree-fre gives incorrect result in su

Re: [Patch] contrib/mklog.py: Improve PR handling (was: git gcc-commit-mklog doesn't extract PR number to ChangeLog)

2021-06-18 Thread Tobias Burnus
On 18.06.21 13:10, Jonathan Wakely wrote: On Fri, 18 Jun 2021 at 12:05, Tobias Burnus wrote: PR c++/12394 - internal compiler error: in write_type, at cp/mangle.c:1517 PR fortran/100123 - -ftree-fre gives incorrect result in subroutine with array declared as length 1 PR c++/12394

Re: [Patch] contrib/mklog.py: Improve PR handling (was: git gcc-commit-mklog doesn't extract PR number to ChangeLog)

2021-06-18 Thread Jakub Jelinek via Gcc
On Fri, Jun 18, 2021 at 12:10:33PM +0100, Jonathan Wakely wrote: > On Fri, 18 Jun 2021 at 12:05, Tobias Burnus wrote: > > But with -p added, it becomes rather nice. For instance: > > > >git diff |./contrib/mklog.py -b foo/12394 -b 100123 -p > > > > nows prints: > > > > PR c++/12394 - internal c

Re: [Patch] contrib/mklog.py: Improve PR handling (was: git gcc-commit-mklog doesn't extract PR number to ChangeLog)

2021-06-18 Thread Jonathan Wakely via Gcc
On Fri, 18 Jun 2021 at 12:05, Tobias Burnus wrote: > But with -p added, it becomes rather nice. For instance: > >git diff |./contrib/mklog.py -b foo/12394 -b 100123 -p > > nows prints: > > PR c++/12394 - internal compiler error: in write_type, at cp/mangle.c:1517 > PR fortran/100123 - -ftree-fr

[Patch] contrib/mklog.py: Improve PR handling (was: git gcc-commit-mklog doesn't extract PR number to ChangeLog)

2021-06-18 Thread Tobias Burnus
On 18.06.21 11:32, Richard Earnshaw via Gcc wrote: On 17/06/2021 18:21, Jakub Jelinek wrote: mklog as is doesn't fill in the details (descriptions of the changes to each function etc.), nor is realiable in many cases, and with Jason's recent change just fills in the first and last part of the fi