Re: [Patch, testsuite] Add missing -gdwarf-2 flag in debug/dwarf2 testcase

2013-04-09 Thread Jason Merrill
On 04/09/2013 11:55 AM, Senthil Kumar Selvaraj wrote: + error_at (loc, "dwarf version is not allowed. " + "Try -gdwarf-%d or -g%d instead.", value, value); Let's be a bit more verbose, maybe + error_at (loc, "%<-gdwarf%s> is ambiguous; " + "use

Re: [Patch, testsuite] Add missing -gdwarf-2 flag in debug/dwarf2 testcase

2013-04-09 Thread Senthil Kumar Selvaraj
On Fri, Apr 05, 2013 at 12:02:49AM +0530, Senthil Kumar Selvaraj wrote: > On Thu, Apr 04, 2013 at 01:41:30PM -0400, Jason Merrill wrote: > > On 04/04/2013 11:48 AM, Senthil Kumar Selvaraj wrote: > > >+Common Var(dwarf_version, 4) Negative(gdwarf-) > > > > I don't think you need to mention the vari

Re: [Patch, testsuite] Add missing -gdwarf-2 flag in debug/dwarf2 testcase

2013-04-04 Thread Senthil Kumar Selvaraj
On Thu, Apr 04, 2013 at 01:41:30PM -0400, Jason Merrill wrote: > On 04/04/2013 11:48 AM, Senthil Kumar Selvaraj wrote: > >+Common Var(dwarf_version, 4) Negative(gdwarf-) > > I don't think you need to mention the variable on this line; it's > already there and statically initialized for gdwarf-. >

Re: [Patch, testsuite] Add missing -gdwarf-2 flag in debug/dwarf2 testcase

2013-04-04 Thread Jason Merrill
On 04/04/2013 11:48 AM, Senthil Kumar Selvaraj wrote: +Common Var(dwarf_version, 4) Negative(gdwarf-) I don't think you need to mention the variable on this line; it's already there and statically initialized for gdwarf-. I wasn't able to get this done in a clean way. To make the gdwarf opt

Re: [Patch, testsuite] Add missing -gdwarf-2 flag in debug/dwarf2 testcase

2013-04-04 Thread Senthil Kumar Selvaraj
On Wed, Apr 03, 2013 at 11:07:04PM -0400, Jason Merrill wrote: > On 04/02/2013 03:25 PM, Senthil Kumar Selvaraj wrote: > >+gdwarf > >+Common UInteger Var(dwarf_default_version, 4) Negative(gdwarf-) > >+Generate debug information in the default DWARF version format > > The Negative options need to

Re: [Patch, testsuite] Add missing -gdwarf-2 flag in debug/dwarf2 testcase

2013-04-03 Thread Jason Merrill
On 04/02/2013 03:25 PM, Senthil Kumar Selvaraj wrote: +gdwarf +Common UInteger Var(dwarf_default_version, 4) Negative(gdwarf-) +Generate debug information in the default DWARF version format The Negative options need to form a circular chain, so gcoff should have Negative(gdwarf) and gdwarf sh

Re: [Patch, testsuite] Add missing -gdwarf-2 flag in debug/dwarf2 testcase

2013-04-02 Thread Senthil Kumar Selvaraj
On Tue, Apr 02, 2013 at 11:09:12AM -0400, Jason Merrill wrote: > On 04/02/2013 09:07 AM, Senthil Kumar Selvaraj wrote: > >Ok, how about the following (tentative) patch? If -gdwarf- is > >specified without any argument, it picks DWARF 4 as the default. > > -gdwarf- looks a bit odd to me; I was thin

Re: [Patch, testsuite] Add missing -gdwarf-2 flag in debug/dwarf2 testcase

2013-04-02 Thread Jason Merrill
On 04/02/2013 09:07 AM, Senthil Kumar Selvaraj wrote: Ok, how about the following (tentative) patch? If -gdwarf- is specified without any argument, it picks DWARF 4 as the default. -gdwarf- looks a bit odd to me; I was thinking -gdwarf without the trailing -. Jason

Re: [Patch, testsuite] Add missing -gdwarf-2 flag in debug/dwarf2 testcase

2013-04-02 Thread Senthil Kumar Selvaraj
On Mon, Apr 01, 2013 at 06:46:29PM -0700, Mike Stump wrote: > On Apr 1, 2013, at 6:43 PM, Jason Merrill wrote: > > On 03/30/2013 02:23 AM, Senthil Kumar Selvaraj wrote: > >> I couldn't find a way to ask gcc to just generate DWARF (default > >> version) either. How should this be fixed? > > > > Ma

Re: [Patch, testsuite] Add missing -gdwarf-2 flag in debug/dwarf2 testcase

2013-04-01 Thread Mike Stump
On Apr 1, 2013, at 6:43 PM, Jason Merrill wrote: > On 03/30/2013 02:23 AM, Senthil Kumar Selvaraj wrote: >> I couldn't find a way to ask gcc to just generate DWARF (default >> version) either. How should this be fixed? > > Maybe we could use -gdwarf for that now, since we stopped using it for DWA

Re: [Patch, testsuite] Add missing -gdwarf-2 flag in debug/dwarf2 testcase

2013-04-01 Thread Jason Merrill
On 03/30/2013 02:23 AM, Senthil Kumar Selvaraj wrote: I couldn't find a way to ask gcc to just generate DWARF (default version) either. How should this be fixed? Maybe we could use -gdwarf for that now, since we stopped using it for DWARF 1 in GCC 3.4. Jason

Re: [Patch, testsuite] Add missing -gdwarf-2 flag in debug/dwarf2 testcase

2013-03-29 Thread Senthil Kumar Selvaraj
On Fri, Mar 29, 2013 at 02:46:49PM -0400, Jason Merrill wrote: > On 03/28/2013 06:09 PM, Mike Stump wrote: > >Hum… I can't help but wonder if there was supposed to be code that checks to > >ensure dwarf is supported and the default before doing the entire test suite. > > That's what I thought, ye

Re: [Patch, testsuite] Add missing -gdwarf-2 flag in debug/dwarf2 testcase

2013-03-29 Thread Jason Merrill
On 03/28/2013 06:09 PM, Mike Stump wrote: Hum… I can't help but wonder if there was supposed to be code that checks to ensure dwarf is supported and the default before doing the entire test suite. That's what I thought, yes. And we don't want to specify -gdwarf-2 explicitly, as now -gdwarf-4

Re: [Patch, testsuite] Add missing -gdwarf-2 flag in debug/dwarf2 testcase

2013-03-28 Thread Mike Stump
On Mar 28, 2013, at 3:57 AM, Senthil Kumar Selvaraj wrote: > On Wed, Mar 27, 2013 at 08:43:53AM -0700, Mike Stump wrote: >> On Mar 27, 2013, at 1:02 AM, Senthil Kumar Selvaraj >> wrote: >>> global-used-types.c in gcc/testsuite/gcc.dg/debug/dwarf2 only specifies >>> -g in dg-options. For a targe

Re: [Patch, testsuite] Add missing -gdwarf-2 flag in debug/dwarf2 testcase

2013-03-28 Thread Senthil Kumar Selvaraj
On Wed, Mar 27, 2013 at 08:43:53AM -0700, Mike Stump wrote: > On Mar 27, 2013, at 1:02 AM, Senthil Kumar Selvaraj > wrote: > > global-used-types.c in gcc/testsuite/gcc.dg/debug/dwarf2 only specifies > > -g in dg-options. For a target that is not configured to generate > > dwarf-2 by default, the

Re: [Patch, testsuite] Add missing -gdwarf-2 flag in debug/dwarf2 testcase

2013-03-27 Thread Mike Stump
On Mar 27, 2013, at 1:02 AM, Senthil Kumar Selvaraj wrote: > global-used-types.c in gcc/testsuite/gcc.dg/debug/dwarf2 only specifies > -g in dg-options. For a target that is not configured to generate > dwarf-2 by default, the test fails looking for specific DWARF strings in > the generated assem

[Patch, testsuite] Add missing -gdwarf-2 flag in debug/dwarf2 testcase

2013-03-27 Thread Senthil Kumar Selvaraj
Hi, global-used-types.c in gcc/testsuite/gcc.dg/debug/dwarf2 only specifies -g in dg-options. For a target that is not configured to generate dwarf-2 by default, the test fails looking for specific DWARF strings in the generated assembly. The patch below changes dg-options to -gdwarf-2. Can someo