Re: “ira_may_move_out_cost” vs “ira_register_move_cost”

2024-06-20 Thread Vladimir Makarov via Gcc
On 6/18/24 03:38, Surya Kumari Jangala wrote: Hi Vladimir, On 14/06/24 10:56 pm, Vladimir Makarov wrote: On 6/13/24 00:34, Surya Kumari Jangala wrote: Hi Vladimir, With my patch for PR111673 (scale the spill/restore cost of callee-save register with the frequency of the entry bb in the routi

Re: “ira_may_move_out_cost” vs “ira_register_move_cost”

2024-06-14 Thread Vladimir Makarov via Gcc
On 6/13/24 00:34, Surya Kumari Jangala wrote: Hi Vladimir, With my patch for PR111673 (scale the spill/restore cost of callee-save register with the frequency of the entry bb in the routine assign_hard_reg() : https://gcc.gnu.org/pipermail/gcc-patches/2023-October/631849.html), the following Li

Re: LRA for avr: Maintain live range info for pseudos assigned to FP?

2023-10-05 Thread Vladimir Makarov via Gcc
On 9/7/23 07:21, senthilkumar.selva...@microchip.com wrote: Hi, One more execution failure for the avr target, this time from gcc.c-torture/execute/bitfld-3.c. Steps to reproduce Enable LRA in avr.cc by removing TARGET_LRA_P hook, build with $ make all-host && make install-host

Re: LRA for avr: help with FP and elimination

2023-08-11 Thread Vladimir Makarov via Gcc
On 8/10/23 07:33, senthilkumar.selva...@microchip.com wrote: Hi Vlad, I can confirm your commit (https://gcc.gnu.org/git?p=gcc.git;a=commit;h=2971ff7b1d564ac04b537d907c70e6093af70832) fixes the above problem, thank you. However, I see execution failures if a pseudo assigned to FP ha

[pushed][LRA]: Implement output stack pointer reloads

2023-08-11 Thread Vladimir Makarov via Gcc
On 8/9/23 16:54, Vladimir Makarov wrote: On 8/9/23 07:15, senthilkumar.selva...@microchip.com wrote: Hi,    After turning on FP -> SP elimination after Vlad fixed    an elimination issue in https://gcc.gnu.org/git?p=gcc.git;a=commit;h=2971ff7b1d564ac04b537d907c70e6093af70832,    I'm now run

[pushed][LRA]: Implement output stack pointer reloads

2023-08-11 Thread Vladimir Makarov via Gcc
On 8/9/23 16:54, Vladimir Makarov wrote: On 8/9/23 07:15, senthilkumar.selva...@microchip.com wrote: Hi,    After turning on FP -> SP elimination after Vlad fixed    an elimination issue in https://gcc.gnu.org/git?p=gcc.git;a=commit;h=2971ff7b1d564ac04b537d907c70e6093af70832,    I'm now run

Re: LRA for avr: Arithmetic on stack pointer

2023-08-09 Thread Vladimir Makarov via Gcc
On 8/9/23 07:15, senthilkumar.selva...@microchip.com wrote: Hi, After turning on FP -> SP elimination after Vlad fixed an elimination issue in https://gcc.gnu.org/git?p=gcc.git;a=commit;h=2971ff7b1d564ac04b537d907c70e6093af70832, I'm now running into reload failure if arithmetic is d

Re: LRA for avr: Handling hard regs set directly at expand

2023-08-02 Thread Vladimir Makarov via Gcc
On 7/17/23 07:33, senthilkumar.selva...@microchip.com wrote: Hi, The avr target has a bunch of patterns that directly set hard regs at expand time, like so (define_expand "cpymemhi" [(parallel [(set (match_operand:BLK 0 "memory_operand" "") (match_operand:BLK 1 "mem

Re: LRA for avr: Clobber with match_dup

2023-07-20 Thread Vladimir Makarov via Gcc
On 7/20/23 07:17, senthilkumar.selva...@microchip.com wrote: Hi, The avr backend has this define_insn_and_split (define_insn_and_split "*tablejump_split" [(set (pc) (unspec:HI [(match_operand:HI 0 "register_operand" "!z,*r,z")] UNSPEC_INDEX_JMP)) (use (l

Re: LRA for avr: help with FP and elimination

2023-07-18 Thread Vladimir Makarov via Gcc
On 7/17/23 03:17, senthilkumar.selva...@microchip.com wrote: On Fri, 2023-07-14 at 09:29 -0400, Vladimir Makarov wrote: If you send me the preprocessed test, I could start to work on it to fix the problems. I think it is hard to fix them right for a person having a little experience with LRA.

Re: LRA for avr: help with FP and elimination

2023-07-14 Thread Vladimir Makarov via Gcc
On 7/13/23 05:27, SenthilKumar.Selvaraj--- via Gcc wrote: Hi, I've been spending some (spare) time checking what it would take to make LRA work for the avr target. Right after I removed the TARGET_LRA_P hook disabling LRA, building libgcc failed with a weird ICE. On the avr,

Re: [IRA] Query about improve_allocation() routine in IRA

2023-04-20 Thread Vladimir Makarov via Gcc
On 4/19/23 14:53, Surya Kumari Jangala wrote: ... I have a few queries: 1. A zero cost seems strange for the regs r14-r31. If using a reg in the set [14..31] has zero cost, then why wasn’t such a reg chosen for r118 in the first place, instead of r3? I guess it is because assign_hard_reg (s

Re: [IRA] Code bloat due to register spills in v9, v10, v11, v12 and master

2022-12-09 Thread Vladimir Makarov via Gcc
On 2022-12-09 14:23, Georg-Johann Lay wrote: There is the following code size regression, filed as https://gcc.gnu.org/PR90706 I am sorry, I feel your frustration. I was not aware of this PR. Unfortunately, the PR was marked as P4 and I have too many open PRs and should prioritize them.