Re: New Clang flag "-fnew-infallible" to mark C++ new as "throw()" and "returns_nonnull"

2021-08-03 Thread Modi Mo via Gcc
On 8/3/21, 4:57 PM, "Jonathan Wakely" wrote: > On Tue, 3 Aug 2021, 23:10 Modi Mo, wrote: > > > > On 8/3/21, 1:51 PM, "Jonathan Wakely" wrote: > > > > > >Could you explain this sentence in the commit message: > > >"Note that the definition of global new is user-replaceable so users > > >

Re: New Clang flag "-fnew-infallible" to mark C++ new as "throw()" and "returns_nonnull"

2021-08-03 Thread Modi Mo via Gcc
On 8/3/21, 1:51 PM, "Jonathan Wakely" wrote: > >Could you explain this sentence in the commit message: >"Note that the definition of global new is user-replaceable so users >should ensure that the one used follows these semantics." AFAICT based on the C++ standard, the user can replac

FYI: New Clang flag "-fnew-infallible" to mark C++ new as "throw()" and "returns_nonnull"

2021-08-03 Thread Modi Mo via Gcc
Hi all, I recently committed support for the "-fnew-infallible" flag in Clang (https://reviews.llvm.org/D105225) to improve non-exceptional performance for code that contains exceptions. Having "new" terminate immediately on failure stops upward exception propagation and leads to significantly

RE: [EXTERNAL] Re: GCC selftest improvements

2020-03-02 Thread Modi Mo via gcc
> From: David Malcolm > > Thanks Modi. > > Before looking at the updated patch in detail, we ought to also address the > legal prerequisites for contributing. > > Does your employer have legal paperwork in place with the FSF for such > contributions? See: > > https://gcc.gnu.org/contribute.ht

RE: [EXTERNAL] Re: GCC selftest improvements

2020-02-25 Thread Modi Mo via gcc
> On 2/12/20 8:53 PM, David Malcolm wrote: > The patch will need an update to the docs; search for > "Tools/packages necessary for building GCC" in > gcc/doc/install.texi, which currently has some paragraphs labelled: >@item ISO C++98 compiler > that will need changing. Added this change in th

RE: [EXTERNAL] Re: GCC selftest improvements

2020-02-13 Thread Modi Mo via gcc
> On 2/12/20 8:53 PM, David Malcolm wrote: > > Thanks for the patch. > > > > Some nitpicks: > > > > Timing-wise, the GCC developer community is focusing on gcc 10 > > bugfixing right now (aka "stage 4" of the release cycle). So this > > patch won't be suitable to commit to master until stage 1 of

RE: [EXTERNAL] Re: GCC selftest improvements

2020-02-12 Thread Modi Mo via gcc
Hey all, I'm picking this work up from Andrew. Last time it was decided that the timing wasn't right to upgrade the minimum version to C++11. Is the timing better now to get this change through? I've attached the patch Andrew prepared. Can I get feedback on the change and some help testing on