Re: sched_4bsd startup crash trying to run a bound thread on an AP that hasn't started

2011-04-26 Thread John Baldwin
On Tuesday, April 26, 2011 3:46:06 pm Ryan Stone wrote: > On Mon, Apr 25, 2011 at 2:58 PM, John Baldwin wrote: > > > > Yes, I would perhaps tweak the comment to reflect the full if statement > > though. Maybe something like: > > > > /* > > * If SMP is started and the thread is pinned or otherwis

Re: sched_4bsd startup crash trying to run a bound thread on an AP that hasn't started

2011-04-26 Thread Ryan Stone
On Mon, Apr 25, 2011 at 2:58 PM, John Baldwin wrote: > > Yes, I would perhaps tweak the comment to reflect the full if statement > though.  Maybe something like: > > /* >  * If SMP is started and the thread is pinned or otherwise limited to >  * a specific set of CPUs, queue the thread to a per-CP

Re: sched_4bsd startup crash trying to run a bound thread on an AP that hasn't started

2011-04-25 Thread John Baldwin
On Wednesday, April 20, 2011 6:02:42 pm Ryan Stone wrote: > On Wed, Apr 6, 2011 at 2:29 PM, John Baldwin wrote: > > I guess one other option would be something like this: > > > >if (smp_started && (td->td_pinned != 0 || td->td_flags & > > TDF_BOUND || > >ts->ts

Re: sched_4bsd startup crash trying to run a bound thread on an AP that hasn't started

2011-04-20 Thread Ryan Stone
On Wed, Apr 6, 2011 at 2:29 PM, John Baldwin wrote: > I guess one other option would be something like this: > >                if (smp_started && (td->td_pinned != 0 || td->td_flags & > TDF_BOUND || >                    ts->ts_flags & TSF_AFFINITY)) { >                        if (td->td_pinned !

Re: sched_4bsd startup crash trying to run a bound thread on an AP that hasn't started

2011-04-06 Thread John Baldwin
On Wednesday, April 06, 2011 1:08:20 pm Ryan Stone wrote: > On Wed, Apr 6, 2011 at 8:36 AM, John Baldwin wrote: > > Hummm. Patching 4BSD to use the same route as ULE may be the best solution > > for now if that is easiest. Alternatively, you could change 4BSD's > > sched_add() to not try to kic

Re: sched_4bsd startup crash trying to run a bound thread on an AP that hasn't started

2011-04-06 Thread Attilio Rao
2011/4/6 Ryan Stone : > On Wed, Apr 6, 2011 at 8:36 AM, John Baldwin wrote: >> Hummm.  Patching 4BSD to use the same route as ULE may be the best solution >> for now if that is easiest.  Alternatively, you could change 4BSD's >> sched_add() to not try to kick other CPUs until smp_started is true.

Re: sched_4bsd startup crash trying to run a bound thread on an AP that hasn't started

2011-04-06 Thread Ryan Stone
On Wed, Apr 6, 2011 at 8:36 AM, John Baldwin wrote: > Hummm.  Patching 4BSD to use the same route as ULE may be the best solution > for now if that is easiest.  Alternatively, you could change 4BSD's > sched_add() to not try to kick other CPUs until smp_started is true. At first I thought that it

Re: sched_4bsd startup crash trying to run a bound thread on an AP that hasn't started

2011-04-06 Thread John Baldwin
On Monday, April 04, 2011 5:10:20 pm Ryan Stone wrote: > I'm running into a bootup crash under sched_4bsd on HEAD. The crash > happens when I have a thread bound to a single CPU that isn't the BSP, > and that thread is scheduled. If the AP that the thread is bound > hasn't been started up, kick_o

sched_4bsd startup crash trying to run a bound thread on an AP that hasn't started

2011-04-04 Thread Ryan Stone
I'm running into a bootup crash under sched_4bsd on HEAD. The crash happens when I have a thread bound to a single CPU that isn't the BSP, and that thread is scheduled. If the AP that the thread is bound hasn't been started up, kick_other_cpu() crashes because pcpu->pc_curthread is NULL for the A