Re: rc.subr: disabling globbing while processing devfs rules

2013-04-01 Thread Andriy Gapon
on 01/04/2013 23:16 John Baldwin said the following: > On Monday, April 01, 2013 3:56:01 pm Jilles Tjoelker wrote: >> On Mon, Apr 01, 2013 at 02:06:50PM -0400, John Baldwin wrote: >>> Why not use 'local -' instead of the $- magic? That is: >> >>> devfs_rulesets_from_file() >>> { >>>local file

Re: rc.subr: disabling globbing while processing devfs rules

2013-04-01 Thread John Baldwin
On Monday, April 01, 2013 3:56:01 pm Jilles Tjoelker wrote: > On Mon, Apr 01, 2013 at 02:06:50PM -0400, John Baldwin wrote: > > Why not use 'local -' instead of the $- magic? That is: > > > devfs_rulesets_from_file() > > { > >local file _err _me - > > > >... > >set -f > >... > >

Re: rc.subr: disabling globbing while processing devfs rules

2013-04-01 Thread Jilles Tjoelker
On Mon, Apr 01, 2013 at 02:06:50PM -0400, John Baldwin wrote: > Why not use 'local -' instead of the $- magic? That is: > devfs_rulesets_from_file() > { >local file _err _me - > >... >set -f >... > } > That would seem to be simpler. I had mentioned this possibility on IRC, but

Re: rc.subr: disabling globbing while processing devfs rules

2013-04-01 Thread John Baldwin
f18efa472c1ab14999247c > Author: Andriy Gapon > Date: Sat Mar 23 10:29:39 2013 +0200 > > rc.subr: disabling globbing while processing devfs rules in > devfs_rulesets_from_file() > > The rules themselves typically have shell-like patterns and it is > incorrect >

rc.subr: disabling globbing while processing devfs rules

2013-03-23 Thread Andriy Gapon
, but I shouldn't have to do it, because the pattern is for /dev/ entries, not arbitrary files in the filesystem namespace. commit 7ce5e9ca5c107e2669f18efa472c1ab14999247c Author: Andriy Gapon Date: Sat Mar 23 10:29:39 2013 +0200 rc.subr: disabling globbing while processing devfs rul