Re: r247835: drm2 code breaks buildkernel

2013-03-05 Thread Konstantin Belousov
On Tue, Mar 05, 2013 at 05:40:34PM +0100, Jean-S?bastien P?dron wrote: > On 05.03.2013 16:37, Konstantin Belousov wrote: > > The patch below is supposed to fix double declaration (it is pathetic that > > clang silently accepts this, while issuing countless useless warnings). > > Also there is a usu

Re: r247835: drm2 code breaks buildkernel

2013-03-05 Thread Jean-Sébastien Pédron
On 05.03.2013 16:37, Konstantin Belousov wrote: > The patch below is supposed to fix double declaration (it is pathetic that > clang silently accepts this, while issuing countless useless warnings). > Also there is a usual workaround for the anonimous union/struct issue. What do you think about "-

Re: r247835: drm2 code breaks buildkernel

2013-03-05 Thread Konstantin Belousov
On Tue, Mar 05, 2013 at 10:54:29AM -0500, Glen Barber wrote: > On Tue, Mar 05, 2013 at 10:48:31AM -0500, Glen Barber wrote: > > On Tue, Mar 05, 2013 at 05:37:36PM +0200, Konstantin Belousov wrote: > > > Glen neglected to even mention that he used gcc (is it true ?), as well > > > as to show the com

Re: r247835: drm2 code breaks buildkernel

2013-03-05 Thread Glen Barber
On Tue, Mar 05, 2013 at 10:48:31AM -0500, Glen Barber wrote: > On Tue, Mar 05, 2013 at 05:37:36PM +0200, Konstantin Belousov wrote: > > Glen neglected to even mention that he used gcc (is it true ?), as well > > as to show the command line invocation of the compiler. Hopefully the > > patch helps.

Re: r247835: drm2 code breaks buildkernel

2013-03-05 Thread Glen Barber
On Tue, Mar 05, 2013 at 05:37:36PM +0200, Konstantin Belousov wrote: > Glen neglected to even mention that he used gcc (is it true ?), as well > as to show the command line invocation of the compiler. Hopefully the > patch helps. Yes, I am using gcc. I'll try your patch and report back. Glen

Re: r247835: drm2 code breaks buildkernel

2013-03-05 Thread Konstantin Belousov
On Tue, Mar 05, 2013 at 03:13:12PM +0100, Jean-S?bastien P?dron wrote: > On 05.03.2013 13:30, Glen Barber wrote: > > dev/drm2/ttm/ttm_lock.h:208: warning: redundant redeclaration of > > 'ttm_write_unlock' [-Wredundant-decls] > > dev/drm2/ttm/ttm_lock.h:134: warning: previous declaration of > > 't

Re: r247835: drm2 code breaks buildkernel

2013-03-05 Thread Jean-Sébastien Pédron
On 05.03.2013 15:54, J.R. Oldroyd wrote: > A fix for these is in my big "get it to compile" patch that I emailed > you both the other day. Sorry, I didn't take the time to read it yet :-/ >>> dev/drm2/ttm/ttm_page_alloc.c:122: warning: declaration does not declare >>> anything >>> dev/drm2/ttm/t

Re: r247835: drm2 code breaks buildkernel

2013-03-05 Thread J.R. Oldroyd
On Tue, 05 Mar 2013 15:13:12 +0100 Jean-Sébastien Pédron wrote: > > On 05.03.2013 13:30, Glen Barber wrote: > > dev/drm2/ttm/ttm_lock.h:208: warning: redundant redeclaration of > > 'ttm_write_unlock' [-Wredundant-decls] > > dev/drm2/ttm/ttm_lock.h:134: warning: previous declaration of > > 'ttm_

Re: r247835: drm2 code breaks buildkernel

2013-03-05 Thread Jean-Sébastien Pédron
On 05.03.2013 13:30, Glen Barber wrote: > dev/drm2/ttm/ttm_lock.h:208: warning: redundant redeclaration of > 'ttm_write_unlock' [-Wredundant-decls] > dev/drm2/ttm/ttm_lock.h:134: warning: previous declaration of > 'ttm_write_unlock' was here > dev/drm2/ttm/ttm_lock.h:220: warning: redundant redec

Re: r247835: drm2 code breaks buildkernel

2013-03-05 Thread Glen Barber
On Tue, Mar 05, 2013 at 12:59:50PM +0100, Hartmann, O. wrote: > > Could you try the patch below? > > > > http://people.freebsd.org/~dumbbell/radeonkms/drm_global-unused-variable.a.patch > > > > Got new sources, I'm at FreeBSD 10.0-CURRENT #1 r247839: Tue Mar 5 > 12:28:12 CET 2013/amd64 and the

Re: r247835: drm2 code breaks buildkernel

2013-03-05 Thread Hartmann, O.
On 03/05/13 11:46, Jean-Sébastien Pédron wrote: > On 05.03.2013 11:20, Hartmann, O. wrote: >> On r247835 build kernel fails: >> >> (...) >> /usr/src/sys/modules/drm2/drm2/../../../dev/drm2/drm_global.c:63:27: >> error: unused variable 'item' [-Werror,-Wunused-variable] >> struct drm

Re: r247835: drm2 code breaks buildkernel

2013-03-05 Thread Jean-Sébastien Pédron
On 05.03.2013 11:20, Hartmann, O. wrote: > On r247835 build kernel fails: > > (...) > /usr/src/sys/modules/drm2/drm2/../../../dev/drm2/drm_global.c:63:27: > error: unused variable 'item' [-Werror,-Wunused-variable] > struct drm_global_item *item = &glob[i]; Could you try the patch

r247835: drm2 code breaks buildkernel

2013-03-05 Thread Hartmann, O.
On r247835 build kernel fails: cc -O2 -pipe -O3 -pipe -march=native -O3 -march=native -pipe -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE -nostdinc -DHAVE_KERNEL_OPTION_HEADERS -include /usr/obj/usr/src/sys/GATE/opt_global.h -I. -I@ -I@/contrib/altq -fno-common -fno-omit-frame-pointer -I/us