Re: if_clone.c allows creating multiple interfaces with the same name

2011-11-30 Thread John Baldwin
On Tuesday, November 29, 2011 9:28:42 am Gleb Smirnoff wrote: > Daan, > > On Tue, Nov 29, 2011 at 01:07:13AM +0100, Daan Vreeken wrote: > D> Thanks for the looking into this and for your quick commit. I like your > twist > D> on the patch with the move from the unit bitmap to allocating unit nu

Re: if_clone.c allows creating multiple interfaces with the same name

2011-11-29 Thread Daan Vreeken
Hi Glebius, On Tuesday 29 November 2011 15:28:42 Gleb Smirnoff wrote: > Daan, > > On Tue, Nov 29, 2011 at 01:07:13AM +0100, Daan Vreeken wrote: > D> Thanks for the looking into this and for your quick commit. I like your > D> twist on the patch with the move from the unit bitmap to allocating un

Re: if_clone.c allows creating multiple interfaces with the same name

2011-11-29 Thread Gleb Smirnoff
Daan, On Tue, Nov 29, 2011 at 01:07:13AM +0100, Daan Vreeken wrote: D> Thanks for the looking into this and for your quick commit. I like your twist D> on the patch with the move from the unit bitmap to allocating unit numbers D> with alloc_unr(9). D> D> I do have two comments on the new code t

Re: if_clone.c allows creating multiple interfaces with the same name

2011-11-28 Thread Daan Vreeken
Hi Glebius, On Friday 25 November 2011 15:32:58 Gleb Smirnoff wrote: > On Fri, Nov 25, 2011 at 05:19:35PM +0400, Gleb Smirnoff wrote: > T> On Thu, Nov 24, 2011 at 09:28:51AM +0100, Daan Vreeken wrote: > T> D> Recently I've discovered a bug in if_clone.c and if.c where the code > allows T> D> multi

Re: if_clone.c allows creating multiple interfaces with the same name

2011-11-25 Thread Gleb Smirnoff
On Fri, Nov 25, 2011 at 05:19:35PM +0400, Gleb Smirnoff wrote: T> On Thu, Nov 24, 2011 at 09:28:51AM +0100, Daan Vreeken wrote: T> D> Recently I've discovered a bug in if_clone.c and if.c where the code allows T> D> multiple interfaces to be created with exactly the same name (which leads to T>

Re: if_clone.c allows creating multiple interfaces with the same name

2011-11-25 Thread Gleb Smirnoff
On Thu, Nov 24, 2011 at 09:28:51AM +0100, Daan Vreeken wrote: D> Recently I've discovered a bug in if_clone.c and if.c where the code allows D> multiple interfaces to be created with exactly the same name (which leads to D> all sorts of other interesting problems). D> I've submitted a PR about th

Re: if_clone.c allows creating multiple interfaces with the same name

2011-11-25 Thread Gleb Smirnoff
On Thu, Nov 24, 2011 at 09:28:51AM +0100, Daan Vreeken wrote: D> Hi All, D> D> Recently I've discovered a bug in if_clone.c and if.c where the code allows D> multiple interfaces to be created with exactly the same name (which leads to D> all sorts of other interesting problems). D> I've submitte

if_clone.c allows creating multiple interfaces with the same name

2011-11-24 Thread Daan Vreeken
Hi All, Recently I've discovered a bug in if_clone.c and if.c where the code allows multiple interfaces to be created with exactly the same name (which leads to all sorts of other interesting problems). I've submitted a PR about this with patches, which can be found here : http://www.fr