Re: fixes for enhanced coredump

2010-04-29 Thread Alfred Perlstein
* John Baldwin [100429 05:46] wrote: > On Wednesday 28 April 2010 1:18:40 pm Alfred Perlstein wrote: > > I was recently working on the enhanced coredumps > > internal to Juniper and realized that there were > > some defects in the code I pushed (mostly due to > > mismerge), can someone please revi

Re: fixes for enhanced coredump

2010-04-29 Thread John Baldwin
On Wednesday 28 April 2010 1:18:40 pm Alfred Perlstein wrote: > I was recently working on the enhanced coredumps > internal to Juniper and realized that there were > some defects in the code I pushed (mostly due to > mismerge), can someone please review? > > 1) don't allocate hostname[] on the sta

fixes for enhanced coredump

2010-04-28 Thread Alfred Perlstein
I was recently working on the enhanced coredumps internal to Juniper and realized that there were some defects in the code I pushed (mostly due to mismerge), can someone please review? 1) don't allocate hostname[] on the stack 2) don't leak the temp buffer in imgact_elf_coredump. thank you, -Alf