Re: sleep bug in taskqueue(9)

2010-11-15 Thread John Baldwin
On Friday, November 12, 2010 4:24:51 pm m...@freebsd.org wrote: > On Fri, Nov 12, 2010 at 12:25 PM, Hans Petter Selasky wrote: > > On Friday 12 November 2010 17:38:38 m...@freebsd.org wrote: > >> On Fri, Nov 12, 2010 at 6:23 AM, Hans Petter Selasky > > wrote: > >> > On Friday 12 November 2010 15

Re: sleep bug in taskqueue(9)

2010-11-12 Thread Hans Petter Selasky
On Friday 12 November 2010 22:24:51 m...@freebsd.org wrote: > On Fri, Nov 12, 2010 at 12:25 PM, Hans Petter Selasky wrote: > > On Friday 12 November 2010 17:38:38 m...@freebsd.org wrote: > >> On Fri, Nov 12, 2010 at 6:23 AM, Hans Petter Selasky > > > > wrote: > >> > On Friday 12 November 2010 1

Re: sleep bug in taskqueue(9)

2010-11-12 Thread mdf
On Fri, Nov 12, 2010 at 12:25 PM, Hans Petter Selasky wrote: > On Friday 12 November 2010 17:38:38 m...@freebsd.org wrote: >> On Fri, Nov 12, 2010 at 6:23 AM, Hans Petter Selasky > wrote: >> > On Friday 12 November 2010 15:18:46 m...@freebsd.org wrote: >> >> On Fri, Nov 12, 2010 at 12:56 AM, Hans

Re: sleep bug in taskqueue(9)

2010-11-12 Thread Hans Petter Selasky
On Friday 12 November 2010 17:38:38 m...@freebsd.org wrote: > On Fri, Nov 12, 2010 at 6:23 AM, Hans Petter Selasky wrote: > > On Friday 12 November 2010 15:18:46 m...@freebsd.org wrote: > >> On Fri, Nov 12, 2010 at 12:56 AM, Hans Petter Selasky > > > > wrote: > >> > On Thursday 29 April 2010 01

Re: sleep bug in taskqueue(9)

2010-11-12 Thread mdf
On Fri, Nov 12, 2010 at 6:23 AM, Hans Petter Selasky wrote: > On Friday 12 November 2010 15:18:46 m...@freebsd.org wrote: >> On Fri, Nov 12, 2010 at 12:56 AM, Hans Petter Selasky > wrote: >> > On Thursday 29 April 2010 01:59:58 Matthew Fleming wrote: >> >> It looks to me like taskqueue_drain(task

Re: sleep bug in taskqueue(9)

2010-11-12 Thread Hans Petter Selasky
On Friday 12 November 2010 15:18:46 m...@freebsd.org wrote: > On Fri, Nov 12, 2010 at 12:56 AM, Hans Petter Selasky wrote: > > On Thursday 29 April 2010 01:59:58 Matthew Fleming wrote: > >> It looks to me like taskqueue_drain(taskqueue_thread, foo) will not > >> correctly detect whether or not a

Re: sleep bug in taskqueue(9)

2010-11-12 Thread mdf
On Fri, Nov 12, 2010 at 12:56 AM, Hans Petter Selasky wrote: > On Thursday 29 April 2010 01:59:58 Matthew Fleming wrote: >> It looks to me like taskqueue_drain(taskqueue_thread, foo) will not >> correctly detect whether or not a task is currently running.  The check >> is against a field in the ta

Re: sleep bug in taskqueue(9)

2010-11-12 Thread Hans Petter Selasky
On Friday 12 November 2010 10:06:10 you wrote: > - queue->tq_running = NULL; forgot this check: /* don't clear if queued again */ if (task->ta_entry.tqe_prev == (void *)1) > + task->ta_entry.tqe_prev = (void *)0; > wakeup

Re: sleep bug in taskqueue(9)

2010-11-12 Thread Hans Petter Selasky
On Thursday 29 April 2010 01:59:58 Matthew Fleming wrote: > struct task { > - STAILQ_ENTRY(task) ta_link; /* link for queue */ > - u_short ta_pending; /* count times queued */ > - u_short ta_priority;/* Priority */ > - task_fn_t *ta_func;

Re: sleep bug in taskqueue(9)

2010-11-12 Thread Hans Petter Selasky
On Thursday 29 April 2010 01:59:58 Matthew Fleming wrote: > It looks to me like taskqueue_drain(taskqueue_thread, foo) will not > correctly detect whether or not a task is currently running. The check > is against a field in the taskqueue struct, but for the taskqueue_thread > queue with more than

Re: sleep bug in taskqueue(9)

2010-04-29 Thread John Baldwin
On Wednesday 28 April 2010 7:59:58 pm Matthew Fleming wrote: > It looks to me like taskqueue_drain(taskqueue_thread, foo) will not > correctly detect whether or not a task is currently running. The check > is against a field in the taskqueue struct, but for the taskqueue_thread > queue with more t