Re: rc.subr: disabling globbing while processing devfs rules

2013-04-01 Thread Andriy Gapon
on 01/04/2013 23:16 John Baldwin said the following: > On Monday, April 01, 2013 3:56:01 pm Jilles Tjoelker wrote: >> On Mon, Apr 01, 2013 at 02:06:50PM -0400, John Baldwin wrote: >>> Why not use 'local -' instead of the $- magic? That is: >> >>> devfs_rulesets_from_file() >>> { >>>local file

Re: rc.subr: disabling globbing while processing devfs rules

2013-04-01 Thread John Baldwin
On Monday, April 01, 2013 3:56:01 pm Jilles Tjoelker wrote: > On Mon, Apr 01, 2013 at 02:06:50PM -0400, John Baldwin wrote: > > Why not use 'local -' instead of the $- magic? That is: > > > devfs_rulesets_from_file() > > { > >local file _err _me - > > > >... > >set -f > >... > >

Re: rc.subr: disabling globbing while processing devfs rules

2013-04-01 Thread Jilles Tjoelker
On Mon, Apr 01, 2013 at 02:06:50PM -0400, John Baldwin wrote: > Why not use 'local -' instead of the $- magic? That is: > devfs_rulesets_from_file() > { >local file _err _me - > >... >set -f >... > } > That would seem to be simpler. I had mentioned this possibility on IRC, but

Re: rc.subr: disabling globbing while processing devfs rules

2013-04-01 Thread John Baldwin
On Saturday, March 23, 2013 4:41:41 am Andriy Gapon wrote: > > Any objections / concerns for the following change? > > An example. > This rule in devfs.rules: > add path da* mode 660 group operator > and this directory: > /data > result in the following rule being actually installed: > 100 path d