Re: git non-time-sequential logs

2021-01-05 Thread Theron
On 1/5/21 2:36 PM, John Baldwin wrote: On 1/4/21 8:52 AM, John Kennedy wrote: On Mon, Jan 04, 2021 at 08:22:56AM -0800, John Kennedy wrote: The git logs in /usr/src aren't time-sequential, so maybe I shouldn't trust those dates above (I pulled it ~Jan 3rd and let it compile overnight), but I'm

Re: git non-time-sequential logs

2021-01-05 Thread Jamie Landeg-Jones
Warner Losh wrote: > > Not having timestamps on files cloned or viewed in cgit.freebsd.org is a > > nightmare too. > > > > I just clicked through and saw several time stamps quite trivially. Could > you be more specific in your complaint? > > Warner I wasn't really complaining - If the git trans

Re: git non-time-sequential logs

2021-01-05 Thread John Baldwin
On 1/4/21 8:52 AM, John Kennedy wrote: > On Mon, Jan 04, 2021 at 08:22:56AM -0800, John Kennedy wrote: >> The git logs in /usr/src aren't time-sequential, so maybe I shouldn't trust >> those dates above (I pulled it ~Jan 3rd and let it compile overnight), but >> I'm going to repull all the sources

Re: git non-time-sequential logs

2021-01-05 Thread Warner Losh
On Tue, Jan 5, 2021 at 6:08 AM Jamie Landeg-Jones wrote: > Ryan Libby wrote: > > > On Mon, Jan 4, 2021 at 10:08 AM Warner Losh wrote: > > ... > > > As for date order, we could also add a commit hook that requires the > date > > > to be properly set, but that creates friction for developers. Is

Re: git non-time-sequential logs

2021-01-05 Thread Warner Losh
On Mon, Jan 4, 2021 at 9:06 PM David G Lawrence wrote: > > Yes. Git has never been a true/pure VCS. However, it does offer enough > > VCS-like features to create a shared distributed versioned tree that's > > useful to the project. > > > > As for date order, we could also add a commit hook that r

Re: git non-time-sequential logs

2021-01-05 Thread Jamie Landeg-Jones
Ryan Libby wrote: > On Mon, Jan 4, 2021 at 10:08 AM Warner Losh wrote: > ... > > As for date order, we could also add a commit hook that requires the date > > to be properly set, but that creates friction for developers. Is that > > friction worth the benefits? I don't think so, but as you say w

Re: git non-time-sequential logs

2021-01-05 Thread grarpamp
>Why is it that the project can't continue to operate the SVN server in > addition to Git, gatewaying with -current as is being done with 12-stable? > As a developer, I definitely need monotonic revision numbers and reliable > dates when I'm trying to troubleshoot a regression. I understand tha

Re: git non-time-sequential logs

2021-01-05 Thread Poul-Henning Kamp
David G Lawrence writes: >Why is it that the project can't continue to operate the SVN server in > addition to Git, gatewaying with -current as is being done with 12-stable? David, With all due respect: That question has been asked and answered so many times now, that it's time to

Re: git non-time-sequential logs

2021-01-05 Thread David G Lawrence
> Yes. Git has never been a true/pure VCS. However, it does offer enough > VCS-like features to create a shared distributed versioned tree that's > useful to the project. > > As for date order, we could also add a commit hook that requires the date > to be properly set, but that creates friction f

Re: git non-time-sequential logs

2021-01-04 Thread Ryan Libby
On Mon, Jan 4, 2021 at 11:00 AM Franco Fichtner wrote: > > > > On 4. Jan 2021, at 7:52 PM, Enji Cooper wrote: > > > > The point is to stop looking at git like svn: commits should be done as > > larger bodies of work (merge commits), as opposed to single atomic commits. > > Er, uh, no. ;) > > Th

Re: git non-time-sequential logs

2021-01-04 Thread John Kennedy
On Mon, Jan 04, 2021 at 07:59:12PM +0100, Franco Fichtner wrote: > The author date stays the same, the committer date is sequential except > that it indicates the local time of the committer doing the cherry-pick > instead of the central server as opposed to svn: > > # git log --format=fuller T

Re: git non-time-sequential logs

2021-01-04 Thread Franco Fichtner
> On 4. Jan 2021, at 7:52 PM, Enji Cooper wrote: > > The point is to stop looking at git like svn: commits should be done as > larger bodies of work (merge commits), as opposed to single atomic commits. Er, uh, no. ;) The author date stays the same, the committer date is sequential except t

Re: git non-time-sequential logs

2021-01-04 Thread Enji Cooper
> On Jan 4, 2021, at 9:05 AM, Alan Somers wrote: > > On Mon, Jan 4, 2021 at 9:58 AM Poul-Henning Kamp > wrote: > >> >> John Kennedy writes: >> >>> This might be perfectly natural and just new to me, but when I look at >> the >>> git logs this morning I se

Re: git non-time-sequential logs

2021-01-04 Thread Ryan Libby
On Mon, Jan 4, 2021 at 10:08 AM Warner Losh wrote: ... > As for date order, we could also add a commit hook that requires the date > to be properly set, but that creates friction for developers. Is that > friction worth the benefits? I don't think so, but as you say we could also > add notes... bu

Re: git non-time-sequential logs

2021-01-04 Thread Warner Losh
On Mon, Jan 4, 2021 at 10:51 AM Poul-Henning Kamp wrote: > > Alan Somers writes: > > > I'll be more frank than phk: it sucks. Git's commit dates are basically > > useless. > > Git is not built as, or to be, version control. > > Git is built to be distrbuted collaboration tool. > > The d

Re: git non-time-sequential logs

2021-01-04 Thread Poul-Henning Kamp
Alan Somers writes: > I'll be more frank than phk: it sucks. Git's commit dates are basically > useless. Git is not built as, or to be, version control. Git is built to be distrbuted collaboration tool. The designed-in version control aspect was always, and only, that the ranting fini

Re: git non-time-sequential logs

2021-01-04 Thread Alan Somers
On Mon, Jan 4, 2021 at 9:58 AM Poul-Henning Kamp wrote: > > John Kennedy writes: > > > This might be perfectly natural and just new to me, but when I look at > the > > git logs this morning I see things like this (editing by me): > > > > Date: Mon Jan 4 17:30:00 2021 +0100 > >

Re: git non-time-sequential logs

2021-01-04 Thread Poul-Henning Kamp
John Kennedy writes: > This might be perfectly natural and just new to me, but when I look at the > git logs this morning I see things like this (editing by me): > > Date: Mon Jan 4 17:30:00 2021 +0100 > Date: Mon Dec 14 18:56:56 2020 +0100 > Date: Tue Dec 15 13:50