code ordering in coredump() (was: Re: cvs commit: src/sys/tools vnode_if.awk)

2002-07-09 Thread Don Lewis
I was studying the following DEBUG_VFS_LOCKS panic and noticed something bothersome about the ordering of the code in coredump(). It looked to me like it made more sense to verify that the file was something that was valid to dump to before doing the vn_start_write() stuff. Rearranging the code a

Re: cvs commit: src/sys/tools vnode_if.awk

2002-07-08 Thread Don Lewis
On 7 Jul, Jeff Roberson wrote: > On Sat, 6 Jul 2002, Jeff Roberson wrote: >> Log: >>- Use 'options DEBUG_VFS_LOCKS' instead of the DEBUG_ALL_VFS_LOCKS >> environment variable to enable the lock verifiction code. > If you have a crash test box I would appreciate it if you would enable

Re: cvs commit: src/sys/tools vnode_if.awk

2002-07-07 Thread Don Lewis
On 7 Jul, Jeff Roberson wrote: > > > On Sun, 7 Jul 2002, Don Lewis wrote: >> Debugger(c0420fe4) at Debugger+0x45 >> vn_rdwr(0,c6737800,c6425000,55ac,0,0,1,8,c22c7200,df241aec,c22cc0c0) at >> vn_rdwr+0x18d >> linker_hints_lookup(c04750a0,c,c62df000,5,0) at >> linker_hints_lookup+0x2d9 >> linker

Re: cvs commit: src/sys/tools vnode_if.awk

2002-07-07 Thread Jeff Roberson
On Sun, 7 Jul 2002, Don Lewis wrote: > > It wasn't able to sucessfully boot with this enabled. I'm hand > transcribing this, so apologies for any typos: > [snip] > > > Debugger(c0420fe4) at Debugger+0x45 > vn_rdwr(0,c6737800,c6425000,55ac,0,0,1,8,c22c7200,df241aec,c22cc0c0) at > vn_rdwr+0x18d

Re: cvs commit: src/sys/tools vnode_if.awk

2002-07-07 Thread Jeff Roberson
On Sun, 7 Jul 2002, Don Lewis wrote: > On 7 Jul, Jeff Roberson wrote: > > On Sat, 6 Jul 2002, Jeff Roberson wrote: > > >>- Use 'options DEBUG_VFS_LOCKS' instead of the DEBUG_ALL_VFS_LOCKS > >> environment variable to enable the lock verifiction code. > > > If you have a crash test box

Re: cvs commit: src/sys/tools vnode_if.awk

2002-07-07 Thread Don Lewis
On 7 Jul, Jeff Roberson wrote: > On Sat, 6 Jul 2002, Jeff Roberson wrote: >>- Use 'options DEBUG_VFS_LOCKS' instead of the DEBUG_ALL_VFS_LOCKS >> environment variable to enable the lock verifiction code. > This was previously disabled because our locking was so bad that we could > not

Re: cvs commit: src/sys/tools vnode_if.awk

2002-07-06 Thread Jeff Roberson
On Sat, 6 Jul 2002, Jeff Roberson wrote: > jeff2002/07/06 23:39:37 PDT > > Modified files: > sys/toolsvnode_if.awk > Log: >- Use 'options DEBUG_VFS_LOCKS' instead of the DEBUG_ALL_VFS_LOCKS > environment variable to enable the lock verifiction code. > > Revi