Re: Turning TESTS on by default

2014-06-10 Thread Julio Merino
On Tue, Jun 10, 2014 at 4:54 PM, Glen Barber wrote: > After reviewing Julio's proposed changes, I realize that there is a way > to avoid populating /usr/tests when building the on-disc filesystem. > I think this will also apply to the WITH_DEBUG_FILES=1 case mentioned. > > It seems I cannot apply

Re: Turning TESTS on by default

2014-06-10 Thread Glen Barber
On Mon, Jun 09, 2014 at 07:27:43PM -0400, Glen Barber wrote: > On Tue, Jun 10, 2014 at 02:15:06AM +0300, Konstantin Belousov wrote: > > On Sun, Jun 08, 2014 at 04:36:45PM -0400, Glen Barber wrote: > > > On Sun, Jun 08, 2014 at 01:33:31PM -0700, Adrian Chadd wrote: > > > > Now, as for how much bloat

Re: Turning TESTS on by default

2014-06-09 Thread Glen Barber
On Tue, Jun 10, 2014 at 02:15:06AM +0300, Konstantin Belousov wrote: > On Sun, Jun 08, 2014 at 04:36:45PM -0400, Glen Barber wrote: > > On Sun, Jun 08, 2014 at 01:33:31PM -0700, Adrian Chadd wrote: > > > Now, as for how much bloat it adds to the CD images... > > > > > > > Enough that it will be t

Re: Turning TESTS on by default

2014-06-09 Thread Konstantin Belousov
On Sun, Jun 08, 2014 at 04:36:45PM -0400, Glen Barber wrote: > On Sun, Jun 08, 2014 at 01:33:31PM -0700, Adrian Chadd wrote: > > Now, as for how much bloat it adds to the CD images... > > > > Enough that it will be turned off for the CDs. I wanted to answer that we should split the question into

Re: Turning TESTS on by default

2014-06-08 Thread Glen Barber
On Sun, Jun 08, 2014 at 01:33:31PM -0700, Adrian Chadd wrote: > Now, as for how much bloat it adds to the CD images... > Enough that it will be turned off for the CDs. Glen pgpSgQfS5INoO.pgp Description: PGP signature

Re: Turning TESTS on by default

2014-06-08 Thread Adrian Chadd
On 8 June 2014 11:52, Julio Merino wrote: > On Sun, Jun 8, 2014 at 1:50 PM, Warren Block wrote: >> How much of an impact does the test suite have in terms of disk space >> (probably not much) > > It clocks at 11MB now on amd64. > >> and buildworld time (possibly not much, either)? > > Haven't mea

Re: Turning TESTS on by default

2014-06-08 Thread Julio Merino
On Sun, Jun 8, 2014 at 1:50 PM, Warren Block wrote: > How much of an impact does the test suite have in terms of disk space > (probably not much) It clocks at 11MB now on amd64. > and buildworld time (possibly not much, either)? Haven't measured. Note, though, that the majority of the existing

Re: Turning TESTS on by default

2014-06-08 Thread Warren Block
On Sun, 8 Jun 2014, Julio Merino wrote: On Fri, Jun 6, 2014 at 11:33 PM, Konstantin Belousov wrote: It is the same as the debugging kernel. The INVARIANTS, WITNESS, DEBUG and DIAGNOSTIC options are not enabled for the user consumption. No; this is not the same at all. All the options you men

Re: Turning TESTS on by default

2014-06-08 Thread Julio Merino
On Sat, Jun 7, 2014 at 3:53 PM, Konstantin Belousov wrote: > Could somebody point out a popular software system that spills the > tests or other developer-only[*] stuff into the production install ? I > immediately remember the perl and its modules which have very extensive > test suite, but the t

Re: Turning TESTS on by default

2014-06-08 Thread Julio Merino
On Fri, Jun 6, 2014 at 11:33 PM, Konstantin Belousov wrote: > It is the same as the debugging kernel. The INVARIANTS, WITNESS, DEBUG > and DIAGNOSTIC options are not enabled for the user consumption. No; this is not the same at all. All the options you mention introduce a performance penalty on t

Re: Turning TESTS on by default

2014-06-07 Thread Konstantin Belousov
On Sat, Jun 07, 2014 at 12:31:01PM -0600, Alan Somers wrote: > On Fri, Jun 6, 2014 at 9:33 PM, Konstantin Belousov > wrote: > > On Fri, Jun 06, 2014 at 03:14:52PM -0400, Julio Merino wrote: > >> Hello all, > >> > >> > >> TL;DR > >> - > >> > >> I plan to turn the TESTS src.conf knob ON by defa

Re: Turning TESTS on by default

2014-06-07 Thread Alan Somers
On Fri, Jun 6, 2014 at 9:33 PM, Konstantin Belousov wrote: > On Fri, Jun 06, 2014 at 03:14:52PM -0400, Julio Merino wrote: >> Hello all, >> >> >> TL;DR >> - >> >> I plan to turn the TESTS src.conf knob ON by default on Tuesday once I >> have been able to perform enough sanity-checks of the bui

Re: Turning TESTS on by default

2014-06-06 Thread Konstantin Belousov
On Fri, Jun 06, 2014 at 03:14:52PM -0400, Julio Merino wrote: > Hello all, > > > TL;DR > - > > I plan to turn the TESTS src.conf knob ON by default on Tuesday once I > have been able to perform enough sanity-checks of the build and all of > them pass. > > The impact of this is that the Free

Re: Turning TESTS on by default

2014-06-06 Thread Kubilay Kocak
On 7/06/2014 5:14 AM, Julio Merino wrote: > Hello all, > > > TL;DR > - > > I plan to turn the TESTS src.conf knob ON by default on Tuesday once I > have been able to perform enough sanity-checks of the build and all of > them pass. > > The impact of this is that the FreeBSD Test Suite (see

Re: Turning TESTS on by default

2014-06-06 Thread Julio Merino
On Fri, Jun 6, 2014 at 3:50 PM, Jilles Tjoelker wrote: > This is certainly useful, but please fix installworld from a read-only > (e.g. NFS) /usr/obj first. I reported this a while ago in > http://lists.freebsd.org/pipermail/freebsd-testing/2014-May/000384.html > "build Kyuafile.auto during buildw

Re: Turning TESTS on by default

2014-06-06 Thread Jilles Tjoelker
On Fri, Jun 06, 2014 at 03:14:52PM -0400, Julio Merino wrote: > TL;DR > - > I plan to turn the TESTS src.conf knob ON by default on Tuesday once I > have been able to perform enough sanity-checks of the build and all of > them pass. > The impact of this is that the FreeBSD Test Suite (see tes