Re: Enabling AESNI by default

2021-01-01 Thread Warner Losh
On Fri, Jan 1, 2021, 1:40 PM Mina Galić wrote: > On Thursday, December 31st, 2020 at 20:51, Allan Jude < > allanj...@freebsd.org> wrote: > > > We've had the AESNI module for quite a few years now, and it has not > caused any problems. > > > > I am wondering if there are any objections to includin

Re: Enabling AESNI by default

2021-01-01 Thread Mina Galić
On Thursday, December 31st, 2020 at 20:51, Allan Jude wrote: > We've had the AESNI module for quite a few years now, and it has not caused > any problems. > > I am wondering if there are any objections to including it in GENERIC, so > that users get the benefit without having to have the "trib

Re: Enabling AESNI by default

2020-12-31 Thread John Baldwin
On 12/31/20 11:51 AM, Allan Jude wrote: > We've had the AESNI module for quite a few years now, and it has not > caused any problems. > > I am wondering if there are any objections to including it in GENERIC, > so that users get the benefit without having to have the "tribal > knowledge" that 'to

Re: Enabling AESNI by default

2020-12-31 Thread John Baldwin
On 12/31/20 12:15 PM, Franco Fichtner wrote: > https://cgit.freebsd.org/src/commit/sys/crypto/aesni?h=stable/12&id=95b37a4ed741fd116809d0f2cb295c4e9977f5b6 > > may have subtly broken a number of IPsec installations by stalling active > connections after certain amounts of traffic transferred. We'

Re: Enabling AESNI by default

2020-12-31 Thread Ian Lepore
On Thu, 2020-12-31 at 14:09 -0800, Rodney W. Grimes wrote: > > We've had the AESNI module for quite a few years now, and it has > > not > > caused any problems. > > > > I am wondering if there are any objections to including it in > > GENERIC, > > so that users get the benefit without having to ha

Re: Enabling AESNI by default

2020-12-31 Thread Alan Somers
On Thu, Dec 31, 2020 at 3:20 PM Kristof Provost wrote: > On 31 Dec 2020, at 23:09, Rodney W. Grimes wrote: > > Its for ever dead code on a large number of machines that do not have > > the hardware for it. I know that is a decreasing set, but imho it > > would be better to somehow ONLY load the

Re: Enabling AESNI by default

2020-12-31 Thread Kristof Provost
On 31 Dec 2020, at 23:09, Rodney W. Grimes wrote: Its for ever dead code on a large number of machines that do not have the hardware for it. I know that is a decreasing set, but imho it would be better to somehow ONLY load the module if you had CPU support for it. The down side is that detectio

Re: Enabling AESNI by default

2020-12-31 Thread Rodney W. Grimes
> We've had the AESNI module for quite a few years now, and it has not > caused any problems. > > I am wondering if there are any objections to including it in GENERIC, > so that users get the benefit without having to have the "tribal > knowledge" that 'to accelerate kernel crypto (GELI, ZFS, IPS

Re: Enabling AESNI by default

2020-12-31 Thread Chris
On 2020-12-31 11:51, Allan Jude wrote: We've had the AESNI module for quite a few years now, and it has not caused any problems. I am wondering if there are any objections to including it in GENERIC, so that users get the benefit without having to have the "tribal knowledge" that 'to accelerate

Re: Enabling AESNI by default

2020-12-31 Thread Ronald Klop
Yes! Took me until last month to notice that I needed to load aesni in loader.conf instead of rc.conf because swap geli is configured before kld_list. Years of optimization thrown away. Regards, Ronald. Van: Allan Jude Datum: 31 december 2020 20:51 Aan: FreeBSD Current Onderwerp: Enabling

Re: Enabling AESNI by default

2020-12-31 Thread Franco Fichtner
https://cgit.freebsd.org/src/commit/sys/crypto/aesni?h=stable/12&id=95b37a4ed741fd116809d0f2cb295c4e9977f5b6 may have subtly broken a number of IPsec installations by stalling active connections after certain amounts of traffic transferred. We're still trying to confirm, but it looks like this ha

Re: Enabling AESNI by default

2020-12-31 Thread Shawn Webb
On Thu, Dec 31, 2020 at 02:51:06PM -0500, Allan Jude wrote: > We've had the AESNI module for quite a few years now, and it has not > caused any problems. > > I am wondering if there are any objections to including it in GENERIC, > so that users get the benefit without having to have the "tribal >