Re: Changes to UART ns8250

2013-10-26 Thread Zbigniew Bodek
Hello again. I've just committed the patch: http://svnweb.freebsd.org/base?view=revision&revision=257170 Thanks and best regards Zbigniew Bodek 2013/10/26 Zbigniew Bodek : > Hello Everyone, > > I'm attaching the newest version of the ns8250 UART patch. > After some discussions I decided to go wi

Re: Changes to UART ns8250

2013-10-25 Thread Zbigniew Bodek
Hello Everyone, I'm attaching the newest version of the ns8250 UART patch. After some discussions I decided to go with busy-wait + timeout solution. The applied delay should handle exotic corner cases (please notice that we can't use ns8250_delay() to get the actual single transmission time since

Re: Changes to UART ns8250

2013-10-09 Thread Zbigniew Bodek
Hello Ganbold. Thank you for testing the patch and pointing those issue out. My detection log from Armada XP: uart0: <16550 or compatible> mem 0xd0012000-0xd001201f irq 41 on simplebus0 uart0: console (115200,n,8,1) uart1: <16550 or compatible> mem 0xd0012100-0xd001211f irq 42 on simplebus0 uart2

Re: Changes to UART ns8250

2013-10-08 Thread Ganbold Tsagaankhuu
On Tue, Oct 8, 2013 at 9:58 AM, Ganbold Tsagaankhuu wrote: > Zbigniew, > > > On Tue, Oct 8, 2013 at 3:54 AM, Zbigniew Bodek wrote: > >> Hello. >> >> I would like to present a patch for ns8250 serial that I would like to >> commit in the near future (if there are no objections). >> >> The patch is

Re: Changes to UART ns8250

2013-10-07 Thread Ganbold Tsagaankhuu
Zbigniew, On Tue, Oct 8, 2013 at 3:54 AM, Zbigniew Bodek wrote: > Hello. > > I would like to present a patch for ns8250 serial that I would like to > commit in the near future (if there are no objections). > > The patch is fixing newest DesignWare UART with busy detection. > During frequency di

Re: Changes to UART ns8250

2013-10-07 Thread Zbigniew Bodek
Hello Ian. Well you can't really perform wake event basing on busy interrupt because we are busy waiting/sleeping i.a. to avoid that interrupt to occur. I tried to use pause() that should switch to another task for the declared amount of time and I got: "panic: mi_switch: switch in a critical sect

Re: Changes to UART ns8250

2013-10-07 Thread Ian Lepore
On Mon, 2013-10-07 at 14:56 -0600, Ian Lepore wrote: > On Mon, 2013-10-07 at 22:36 +0200, Zbigniew Bodek wrote: > > Hello Adrian, > > > > Thank you for your remarks. > > Please check my answers in-line. > > > > Best regards > > Zbigniew Bodek > > > > > > 2013/10/7 Adrian Chadd > > > > > Hi, >

Re: Changes to UART ns8250

2013-10-07 Thread Ian Lepore
On Mon, 2013-10-07 at 22:36 +0200, Zbigniew Bodek wrote: > Hello Adrian, > > Thank you for your remarks. > Please check my answers in-line. > > Best regards > Zbigniew Bodek > > > 2013/10/7 Adrian Chadd > > > Hi, > > > > You should add: > > > > * a loop counter, to break out after a while; >

Re: Changes to UART ns8250

2013-10-07 Thread Zbigniew Bodek
Hello Adrian, Thank you for your remarks. Please check my answers in-line. Best regards Zbigniew Bodek 2013/10/7 Adrian Chadd > Hi, > > You should add: > > * a loop counter, to break out after a while; > [ZBB] In general as long as UART is busy we cannot proceed but if the timeout occurs we c

Re: Changes to UART ns8250

2013-10-07 Thread Adrian Chadd
I'd love to see a linux style way of saying "I'd like to sleep from roughly this time interval to this time interval; feel free to do what you need." Then yes, it could be implemented as a sleep wakeup from a timer, or as a call to a hypervisor to do the same, or .. or... -adrian On 7 October

Re: Changes to UART ns8250

2013-10-07 Thread Ian Lepore
On Mon, 2013-10-07 at 13:15 -0700, Adrian Chadd wrote: > Hi, > > You should add: > > *[snip] > * a DELAY(1) or something. > Why? Why oh why do people write while (!read_some_status_register()) DELAY(n); when DELAY() is implemented as, roughly: while (read_some_counter_register() <

Re: Changes to UART ns8250

2013-10-07 Thread Adrian Chadd
Hi, You should add: * a loop counter, to break out after a while; * a DELAY(1) or something. -adrian On 7 October 2013 12:54, Zbigniew Bodek wrote: > Hello. > > I would like to present a patch for ns8250 serial that I would like to > commit in the near future (if there are no objections).